diff mbox series

[1/3] Add vec::reverse.

Message ID 8332734ea696b10f03be75eda7fc854174800794.1527245880.git.mliska@suse.cz
State New
Headers show
Series Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 9 | expand

Commit Message

Martin Liška May 22, 2018, 12:15 p.m. UTC 
gcc/ChangeLog:

2018-05-25  Martin Liska  <mliska@suse.cz>
	    David Malcolm  <dmalcolm@redhat.com>

	* vec.c (test_reverse): New.
	(vec_c_tests): Add new test.
	* vec.h (vl_ptr>::reverse): New function.
---
 gcc/vec.c | 38 ++++++++++++++++++++++++++++++++++++++
 gcc/vec.h | 14 ++++++++++++++
 2 files changed, 52 insertions(+)

Comments

Richard Biener May 28, 2018, 11:24 a.m. UTC | #1 
On Fri, May 25, 2018 at 1:04 PM marxin <mliska@suse.cz> wrote:


> gcc/ChangeLog:

> 2018-05-25  Martin Liska  <mliska@suse.cz>
>              David Malcolm  <dmalcolm@redhat.com>

>          * vec.c (test_reverse): New.
>          (vec_c_tests): Add new test.
>          * vec.h (vl_ptr>::reverse): New function.

OK.
Richard.

> ---
>   gcc/vec.c | 38 ++++++++++++++++++++++++++++++++++++++
>   gcc/vec.h | 14 ++++++++++++++
>   2 files changed, 52 insertions(+)
Jeff Law June 13, 2018, 1:54 a.m. UTC | #2 
On 05/22/2018 06:15 AM, marxin wrote:
> 
> gcc/ChangeLog:
> 
> 2018-05-25  Martin Liska  <mliska@suse.cz>
> 	    David Malcolm  <dmalcolm@redhat.com>
> 
> 	* vec.c (test_reverse): New.
> 	(vec_c_tests): Add new test.
> 	* vec.h (vl_ptr>::reverse): New function.
OK.  Seems generally useful, so from my point of view it can go in
immediately.

jeff
diff mbox series

Patch

diff --git a/gcc/vec.c b/gcc/vec.c
index 2941715a34a..beb857fd838 100644
--- a/gcc/vec.c
+++ b/gcc/vec.c
@@ -476,6 +476,43 @@  test_qsort ()
   ASSERT_EQ (10, v.length ());
 }
 
+/* Verify that vec::reverse works correctly.  */
+
+static void
+test_reverse ()
+{
+  /* Reversing an empty vec ought to be a no-op.  */
+  {
+    auto_vec <int> v;
+    ASSERT_EQ (0, v.length ());
+    v.reverse ();
+    ASSERT_EQ (0, v.length ());
+  }
+
+  /* Verify reversing a vec with even length.  */
+  {
+    auto_vec <int> v;
+    safe_push_range (v, 0, 4);
+    v.reverse ();
+    ASSERT_EQ (3, v[0]);
+    ASSERT_EQ (2, v[1]);
+    ASSERT_EQ (1, v[2]);
+    ASSERT_EQ (0, v[3]);
+    ASSERT_EQ (4, v.length ());
+  }
+
+  /* Verify reversing a vec with odd length.  */
+  {
+    auto_vec <int> v;
+    safe_push_range (v, 0, 3);
+    v.reverse ();
+    ASSERT_EQ (2, v[0]);
+    ASSERT_EQ (1, v[1]);
+    ASSERT_EQ (0, v[2]);
+    ASSERT_EQ (3, v.length ());
+  }
+}
+
 /* Run all of the selftests within this file.  */
 
 void
@@ -492,6 +529,7 @@  vec_c_tests ()
   test_unordered_remove ();
   test_block_remove ();
   test_qsort ();
+  test_reverse ();
 }
 
 } // namespace selftest
diff --git a/gcc/vec.h b/gcc/vec.h
index 2d1f468ca1c..a9f3bcf09eb 100644
--- a/gcc/vec.h
+++ b/gcc/vec.h
@@ -1389,6 +1389,7 @@  public:
   T *bsearch (const void *key, int (*compar)(const void *, const void *));
   unsigned lower_bound (T, bool (*)(const T &, const T &)) const;
   bool contains (const T &search) const;
+  void reverse (void);
 
   bool using_auto_storage () const;
 
@@ -1900,6 +1901,19 @@  vec<T, va_heap, vl_ptr>::contains (const T &search) const
   return m_vec ? m_vec->contains (search) : false;
 }
 
+/* Reverse content of the vector.  */
+
+template<typename T>
+inline void
+vec<T, va_heap, vl_ptr>::reverse (void)
+{
+  unsigned l = length ();
+  T *ptr = address ();
+
+  for (unsigned i = 0; i < l / 2; i++)
+    std::swap (ptr[i], ptr[l - i - 1]);
+}
+
 template<typename T>
 inline bool
 vec<T, va_heap, vl_ptr>::using_auto_storage () const