diff mbox series

bochs-display: add missing break

Message ID 20180525045344.28347-1-kraxel@redhat.com
State New
Headers show
Series bochs-display: add missing break | expand

Commit Message

Gerd Hoffmann May 25, 2018, 4:53 a.m. UTC 
Fixes: CID 1391291
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/bochs-display.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ján Tomko May 27, 2018, 9:15 a.m. UTC | #1 
On Fri, May 25, 2018 at 06:53:44AM +0200, Gerd Hoffmann wrote:
>Fixes: CID 1391291
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> hw/display/bochs-display.c | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Philippe Mathieu-Daudé May 27, 2018, 8:01 p.m. UTC | #2 
On 05/25/2018 01:53 AM, Gerd Hoffmann wrote:
> Fixes: CID 1391291
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/bochs-display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index c33524b558..1187d77576 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -158,6 +158,7 @@ static int bochs_display_get_mode(BochsDisplayState *s,
>          /* best effort: support native endianess only */
>          mode->format = PIXMAN_r5g6b5;
>          mode->bytepp = 2;
> +        break;

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>      case 32:
>          mode->format = s->big_endian_fb
>              ? PIXMAN_BE_x8r8g8b8
>
diff mbox series

Patch

diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index c33524b558..1187d77576 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -158,6 +158,7 @@  static int bochs_display_get_mode(BochsDisplayState *s,
         /* best effort: support native endianess only */
         mode->format = PIXMAN_r5g6b5;
         mode->bytepp = 2;
+        break;
     case 32:
         mode->format = s->big_endian_fb
             ? PIXMAN_BE_x8r8g8b8