Revert "Makefile: Don't suppress warnings from DTC"

Message ID 20180525035336.7631-1-joel@jms.id.au
State Rejected
Headers show
Series
  • Revert "Makefile: Don't suppress warnings from DTC"
Related show

Commit Message

Joel Stanley May 25, 2018, 3:53 a.m.
This reverts commit dc35dbc74cd930778d04186fd35aebb827c56e8a.

There appears to still be a number of warnings from the dtc step. This
may depend on the configuration of the system, so suppress the warnings
until we have those issues worked out.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
I am using 1.4.5 on Ubuntu 18.04.

 Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Amitay Isaacs May 25, 2018, 4:06 a.m. | #1
On Fri, 2018-05-25 at 13:23 +0930, Joel Stanley wrote:
> This reverts commit dc35dbc74cd930778d04186fd35aebb827c56e8a.
> 
> There appears to still be a number of warnings from the dtc step.
> This
> may depend on the configuration of the system, so suppress the
> warnings
> until we have those issues worked out.

The errors are not related to the system configuration, but purely bugs
in the generated dts.  Let's fix the problem and not get rid of
symptom. :-)

I have a patch coming with some more fixes to device trees.

> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> I am using 1.4.5 on Ubuntu 18.04.
> 
>  Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index a5e89c4e26bc..3dd62cf1e1b7 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -83,7 +83,7 @@ GEN_V_ = $(GEN_V_$(AM_DEFAULT_VERBOSITY))
>  GEN_V_0 = @echo "  GEN     " $@;
>  
>  %.dts: %.dts.m4
> -	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -I dts -O dts > $@
> +	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -q -I dts -O dts > $@
>  
>  %.dtsi: %.dtsi.m4
>  	$(M4_V)$(M4) -I$(dir $<) $< > $@
> @@ -93,7 +93,7 @@ p9r-fsi.dts: p9r-fsi.dts.m4 p9-fsi.dtsi
>  p9z-fsi.dts: p9z-fsi.dts.m4 p9-fsi.dtsi
>  
>  %.dtb: %.dts
> -	$(DTC_V)$(DTC) -i$(dir $@) -I dts $< -O dtb > $@
> +	$(DTC_V)$(DTC) -q -i$(dir $@) -I dts $< -O dtb > $@
>  
>  %.dt.h: %.dtb
>  	$(GEN_V)$(srcdir)/generate_dt_header.sh $< > $@
> -- 
> 2.17.0
> 

Amitay.
Alistair Popple June 4, 2018, 1:41 a.m. | #2
On Friday, 25 May 2018 2:06:46 PM AEST Amitay Isaacs wrote:
> On Fri, 2018-05-25 at 13:23 +0930, Joel Stanley wrote:
> > This reverts commit dc35dbc74cd930778d04186fd35aebb827c56e8a.
> > 
> > There appears to still be a number of warnings from the dtc step.
> > This
> > may depend on the configuration of the system, so suppress the
> > warnings
> > until we have those issues worked out.
> 
> The errors are not related to the system configuration, but purely bugs
> in the generated dts.  Let's fix the problem and not get rid of
> symptom. :-)
> 
> I have a patch coming with some more fixes to device trees.

Thanks Joel, but it seems Amitay's latest patch series includes a fix for the
problem so I will take those instead. The warnings were probably missed the
first time round as we don't always build all device trees, only what is
relevant for the specific target host (eg. for x86_64 we only compile the fake
dt).

- Alistair

> > 
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > I am using 1.4.5 on Ubuntu 18.04.
> > 
> >  Makefile.am | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index a5e89c4e26bc..3dd62cf1e1b7 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -83,7 +83,7 @@ GEN_V_ = $(GEN_V_$(AM_DEFAULT_VERBOSITY))
> >  GEN_V_0 = @echo "  GEN     " $@;
> >  
> >  %.dts: %.dts.m4
> > -	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -I dts -O dts > $@
> > +	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -q -I dts -O dts > $@
> >  
> >  %.dtsi: %.dtsi.m4
> >  	$(M4_V)$(M4) -I$(dir $<) $< > $@
> > @@ -93,7 +93,7 @@ p9r-fsi.dts: p9r-fsi.dts.m4 p9-fsi.dtsi
> >  p9z-fsi.dts: p9z-fsi.dts.m4 p9-fsi.dtsi
> >  
> >  %.dtb: %.dts
> > -	$(DTC_V)$(DTC) -i$(dir $@) -I dts $< -O dtb > $@
> > +	$(DTC_V)$(DTC) -q -i$(dir $@) -I dts $< -O dtb > $@
> >  
> >  %.dt.h: %.dtb
> >  	$(GEN_V)$(srcdir)/generate_dt_header.sh $< > $@
> 
> Amitay.
>

Patch

diff --git a/Makefile.am b/Makefile.am
index a5e89c4e26bc..3dd62cf1e1b7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -83,7 +83,7 @@  GEN_V_ = $(GEN_V_$(AM_DEFAULT_VERBOSITY))
 GEN_V_0 = @echo "  GEN     " $@;
 
 %.dts: %.dts.m4
-	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -I dts -O dts > $@
+	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -q -I dts -O dts > $@
 
 %.dtsi: %.dtsi.m4
 	$(M4_V)$(M4) -I$(dir $<) $< > $@
@@ -93,7 +93,7 @@  p9r-fsi.dts: p9r-fsi.dts.m4 p9-fsi.dtsi
 p9z-fsi.dts: p9z-fsi.dts.m4 p9-fsi.dtsi
 
 %.dtb: %.dts
-	$(DTC_V)$(DTC) -i$(dir $@) -I dts $< -O dtb > $@
+	$(DTC_V)$(DTC) -q -i$(dir $@) -I dts $< -O dtb > $@
 
 %.dt.h: %.dtb
 	$(GEN_V)$(srcdir)/generate_dt_header.sh $< > $@