From patchwork Mon Nov 17 19:20:29 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 9201 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A26DEDDE04 for ; Tue, 18 Nov 2008 06:21:05 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbYKQTUj (ORCPT ); Mon, 17 Nov 2008 14:20:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751589AbYKQTUj (ORCPT ); Mon, 17 Nov 2008 14:20:39 -0500 Received: from gw1.cosmosbay.com ([86.65.150.130]:33944 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbYKQTUj (ORCPT ); Mon, 17 Nov 2008 14:20:39 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by gw1.cosmosbay.com (8.13.7/8.13.7) with ESMTP id mAHJKW5E031215; Mon, 17 Nov 2008 20:20:32 +0100 Message-ID: <4921C3FD.106@cosmosbay.com> Date: Mon, 17 Nov 2008 20:20:29 +0100 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Joe Perches , David Miller CC: netdev@vger.kernel.org Subject: Re: [PATCH] net: Cleanup of af_unix References: <49210AE7.3050405@cosmosbay.com> <20081116.223209.239966240.davem@davemloft.net> <4921133D.6070800@cosmosbay.com> <1226907282.4037.31.camel@localhost> In-Reply-To: <1226907282.4037.31.camel@localhost> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Mon, 17 Nov 2008 20:20:33 +0100 (CET) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Joe Perches a écrit : > On Mon, 2008-11-17 at 07:46 +0100, Eric Dumazet wrote: >> [PATCH] net: Cleanup of af_unix >> >> This is a pure cleanup of net/unix/af_unix.c to meet current code style standards >> >> Signed-off-by: Eric Dumazet >> --- >> net/unix/af_unix.c | 117 ++++++++++++++++++++----------------------- >> 1 files changed, 55 insertions(+), 62 deletions(-) >> plain text document attachment (af_unix_cleanup.patch) >> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c >> index 4a39771..58db2a2 100644 >> --- a/net/unix/af_unix.c >> +++ b/net/unix/af_unix.c >> @@ -354,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk) >> WARN_ON(!sk_unhashed(sk)); >> WARN_ON(sk->sk_socket); >> if (!sock_flag(sk, SOCK_DEAD)) { >> - printk("Attempt to release alive unix socket: %p\n", sk); >> + printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", sk); >> return; >> } >> > > Well, perhaps not quite pure. > The KERN_ level selection is debatable. > This could or perhaps should be KERN_INFO. Thanks Joe [PATCH] net: af_unix should use KERN_INFO instead of KERN_DEBUG As spotted by Joe Perches, we should use KERN_INFO in unix_sock_destructor() Signed-off-by: Eric Dumazet diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index f2cf3f5..da3e804 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -353,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk) WARN_ON(!sk_unhashed(sk)); WARN_ON(sk->sk_socket); if (!sock_flag(sk, SOCK_DEAD)) { - printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", sk); + printk(KERN_INFO "Attempt to release alive unix socket: %p\n", sk); return; }