| Message ID | 20180524194835.14700-1-chenbo@pdx.edu |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | 8139too: Remove unnecessary netif_napi_del() | expand |
From: Bo Chen <chenbo@pdx.edu> Date: Thu, 24 May 2018 12:48:35 -0700 > The call to free_netdev() in __rtl8139_cleanup_dev() clears the network device > napi list, and explicit calls to netif_napi_del() are unnecessary. > > Signed-off-by: Bo Chen <chenbo@pdx.edu> Since this is just unnecessary work and not a bug, applied to net-next. Thanks.
diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c index d118da5a10a2..ffd68a7bc9e1 100644 --- a/drivers/net/ethernet/realtek/8139too.c +++ b/drivers/net/ethernet/realtek/8139too.c @@ -1104,7 +1104,6 @@ static int rtl8139_init_one(struct pci_dev *pdev, return 0; err_out: - netif_napi_del(&tp->napi); __rtl8139_cleanup_dev (dev); pci_disable_device (pdev); return i; @@ -1119,7 +1118,6 @@ static void rtl8139_remove_one(struct pci_dev *pdev) assert (dev != NULL); cancel_delayed_work_sync(&tp->thread); - netif_napi_del(&tp->napi); unregister_netdev (dev);
The call to free_netdev() in __rtl8139_cleanup_dev() clears the network device napi list, and explicit calls to netif_napi_del() are unnecessary. Signed-off-by: Bo Chen <chenbo@pdx.edu> --- drivers/net/ethernet/realtek/8139too.c | 2 -- 1 file changed, 2 deletions(-)