[4/6] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()
diff mbox series

Message ID 20180524072323.22115-4-marek.vasut+renesas@gmail.com
State Superseded
Headers show
  • [1/6] PCI: rcar: Pull bus clock enable/disable from rcar_pcie_get_resources()
Related show

Commit Message

Marek Vasut May 24, 2018, 7:23 a.m. UTC
The data link active signal usually takes ~20 uSec to be asserted,
poll the bit more often to avoid useless delays in this function.
Use udelay() instead of usleep() for such a small delay as suggested
by the timer documentation and because this will be used in atomic
context later on when the suspend/resume patches land.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-renesas-soc@vger.kernel.org
V2: s/content/context in commit message
V3: Add cpu_relax()
 drivers/pci/host/pcie-rcar.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index d6a7e8482dcf..4843a4dc6059 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -546,13 +546,14 @@  static int rcar_pcie_wait_for_phyrdy(struct rcar_pcie *pcie)
 static int rcar_pcie_wait_for_dl(struct rcar_pcie *pcie)
-	unsigned int timeout = 10;
+	unsigned int timeout = 10000;
 	while (timeout--) {
 		if ((rcar_pci_read_reg(pcie, PCIETSTR) & DATA_LINK_ACTIVE))
 			return 0;
-		msleep(5);
+		udelay(5);
+		cpu_relax();
 	return -ETIMEDOUT;