From patchwork Tue Apr 19 08:44:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaohua Li X-Patchwork-Id: 91938 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 37D8AB7000 for ; Tue, 19 Apr 2011 18:45:10 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020Ab1DSIpI (ORCPT ); Tue, 19 Apr 2011 04:45:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:45250 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788Ab1DSIpH (ORCPT ); Tue, 19 Apr 2011 04:45:07 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 19 Apr 2011 01:45:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,238,1301900400"; d="scan'208";a="735432103" Received: from sli10-conroe.sh.intel.com (HELO [10.239.36.19]) ([10.239.36.19]) by orsmga001.jf.intel.com with ESMTP; 19 Apr 2011 01:44:51 -0700 Subject: [PATCH 2/2]SATA: enable flush non-queueable From: Shaohua Li To: lkml , linux-ide Cc: Jens Axboe , Jeff Garzik , Christoph Hellwig , Tejun Heo Date: Tue, 19 Apr 2011 16:44:49 +0800 Message-ID: <1303202689.3981.217.camel@sli10-conroe> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Set SATA queue flush non-queueable. Running below test with a AHCI controller and ext4 filesystem, below patch gives around ~5% speedup. sysbench --test fileio --file-test-mode rndrw --num-threads 16 \ --file-total-size 2500MB --max-requests 150000 --max-time 3000 Signed-off-by: Shaohua Li --- drivers/ata/libata-scsi.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux/drivers/ata/libata-scsi.c =================================================================== --- linux.orig/drivers/ata/libata-scsi.c 2011-04-19 14:54:37.000000000 +0800 +++ linux/drivers/ata/libata-scsi.c 2011-04-19 14:58:54.000000000 +0800 @@ -3424,7 +3424,9 @@ void ata_scsi_scan_host(struct ata_port sdev = __scsi_add_device(ap->scsi_host, channel, id, 0, NULL); if (!IS_ERR(sdev)) { + struct request_queue *q = sdev->request_queue; dev->sdev = sdev; + blk_set_queue_flush_queueable(q, false); scsi_device_put(sdev); } else { dev->sdev = NULL;