[1/1] lib/tst_test.sh: Silence getopts

Message ID 20180523083055.20338-1-pvorel@suse.cz
State Accepted
Delegated to: Cyril Hrubis
Headers show
Series
  • [1/1] lib/tst_test.sh: Silence getopts
Related show

Commit Message

Petr Vorel May 23, 2018, 8:30 a.m.
We handle the error already there, so there is no point printing
one more redundant message that doesn't have LTP format.

Suggested-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/lib/tst_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyril Hrubis July 25, 2018, 1:02 p.m. | #1
Hi!
I would says this is obvious enough to be commited without review.

But anyways acked, and sorry for neglecting this for so long.
Petr Vorel July 26, 2018, 7:27 a.m. | #2
Hi Cyril,

> Hi!
> I would says this is obvious enough to be commited without review.

> But anyways acked, and sorry for neglecting this for so long.

Pushed. Thanks for your review!
I consider new lib sources something which needs a review, but in this case I
was probably too careful.


Kind regards,
Petr

Patch

diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index 464c4c41e..ac315075f 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -265,7 +265,7 @@  tst_run()
 
 	OPTIND=1
 
-	while getopts "hi:$TST_OPTS" name $TST_ARGS; do
+	while getopts ":hi:$TST_OPTS" name $TST_ARGS; do
 		case $name in
 		'h') tst_usage; exit 0;;
 		'i') TST_ITERATIONS=$OPTARG;;