diff mbox series

[U-Boot] fit: Enable fitImage by default if OF_LIBFDT is enabled

Message ID 20180522224956.4078-1-marek.vasut+renesas@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [U-Boot] fit: Enable fitImage by default if OF_LIBFDT is enabled | expand

Commit Message

Marek Vasut May 22, 2018, 10:49 p.m. UTC
Enable fitImage by default on systems which already use libfdt.
The fitImage has many benefits over zImage and supersedes legacy
uImage, so enable it by default where possible to make it widely
available.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Tom Rini <trini@konsulko.com>
---
NOTE: And make my life easier, so that every contemporary board I
      look at supports a civilized contemporary boot image format
      and I don't have to mess around to find the right combo of
      zImage or uImage and DTB and the right load addresses and
      keep loading gazilion of files every time I boot a board.
---
 Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini June 8, 2018, 11:18 a.m. UTC | #1
On Wed, May 23, 2018 at 12:49:56AM +0200, Marek Vasut wrote:

> Enable fitImage by default on systems which already use libfdt.
> The fitImage has many benefits over zImage and supersedes legacy
> uImage, so enable it by default where possible to make it widely
> available.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> NOTE: And make my life easier, so that every contemporary board I
>       look at supports a civilized contemporary boot image format
>       and I don't have to mess around to find the right combo of
>       zImage or uImage and DTB and the right load addresses and
>       keep loading gazilion of files every time I boot a board.

You need to run this through travis or otherwise build the world.  A
number of platforms fail due to size constraints and a few others (snow
for example) fail for other reasons.  Thanks!
Marek Vasut June 8, 2018, 2:18 p.m. UTC | #2
On 06/08/2018 01:18 PM, Tom Rini wrote:
> On Wed, May 23, 2018 at 12:49:56AM +0200, Marek Vasut wrote:
> 
>> Enable fitImage by default on systems which already use libfdt.
>> The fitImage has many benefits over zImage and supersedes legacy
>> uImage, so enable it by default where possible to make it widely
>> available.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> ---
>> NOTE: And make my life easier, so that every contemporary board I
>>       look at supports a civilized contemporary boot image format
>>       and I don't have to mess around to find the right combo of
>>       zImage or uImage and DTB and the right load addresses and
>>       keep loading gazilion of files every time I boot a board.
> 
> You need to run this through travis or otherwise build the world.  A
> number of platforms fail due to size constraints and a few others (snow
> for example) fail for other reasons.  Thanks!

Lovely, so how do we constrain those ? btw I'd have expected snow to
have fitImage enabled already ?
Tom Rini June 9, 2018, 12:11 a.m. UTC | #3
On Fri, Jun 08, 2018 at 04:18:43PM +0200, Marek Vasut wrote:
> On 06/08/2018 01:18 PM, Tom Rini wrote:
> > On Wed, May 23, 2018 at 12:49:56AM +0200, Marek Vasut wrote:
> > 
> >> Enable fitImage by default on systems which already use libfdt.
> >> The fitImage has many benefits over zImage and supersedes legacy
> >> uImage, so enable it by default where possible to make it widely
> >> available.
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> >> Cc: Michal Simek <michal.simek@xilinx.com>
> >> Cc: Tom Rini <trini@konsulko.com>
> >> ---
> >> NOTE: And make my life easier, so that every contemporary board I
> >>       look at supports a civilized contemporary boot image format
> >>       and I don't have to mess around to find the right combo of
> >>       zImage or uImage and DTB and the right load addresses and
> >>       keep loading gazilion of files every time I boot a board.
> > 
> > You need to run this through travis or otherwise build the world.  A
> > number of platforms fail due to size constraints and a few others (snow
> > for example) fail for other reasons.  Thanks!
> 
> Lovely, so how do we constrain those ? btw I'd have expected snow to
> have fitImage enabled already ?

Well, I would suggest updating their defconfigs to have the feature
disabled.  snow was failing for some other reason, that I'm still pretty
sure was part of this patch and not some of the others I asked for
changes on.
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 9fd9de1772..7e0c736027 100644
--- a/Kconfig
+++ b/Kconfig
@@ -223,6 +223,7 @@  config FIT
 	bool "Support Flattened Image Tree"
 	select MD5
 	select SHA1
+	default y if OF_LIBFDT
 	help
 	  This option allows you to boot the new uImage structure,
 	  Flattened Image Tree.  FIT is formally a FDT, which can include