| Message ID | 1526987792-56861-2-git-send-email-michal.vokac@ysoft.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add support for QCA8334 switch | expand |
On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > The CPU port default link settings can be reconfigured using > a fixed-link sub-node. > > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> > --- > Changes in v2: > - Add commit message and document fixed-link binding. > > .../devicetree/bindings/net/dsa/qca8k.txt | 23 +++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 9c67ee4..15b9057 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -2,7 +2,10 @@ > > Required properties: > > -- compatible: should be "qca,qca8337" > +- compatible: should be one of: > + "qca,qca8334" > + "qca,qca8337" > + > - #size-cells: must be 0 > - #address-cells: must be 1 > > @@ -14,6 +17,20 @@ port and PHY id, each subnode describing a port needs to have a valid phandle > referencing the internal PHY connected to it. The CPU port of this switch is > always port 0. > > +A CPU port node has the following optional property: s/property/node/ Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>
On 22.5.2018 21:40, Rob Herring wrote: > On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: >> Add support for the four-port variant of the Qualcomm QCA833x switch. >> >> The CPU port default link settings can be reconfigured using >> a fixed-link sub-node. >> >> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> >> --- >> Changes in v2: >> - Add commit message and document fixed-link binding. >> >> .../devicetree/bindings/net/dsa/qca8k.txt | 23 +++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt >> index 9c67ee4..15b9057 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt >> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt >> @@ -2,7 +2,10 @@ >> >> Required properties: >> >> -- compatible: should be "qca,qca8337" >> +- compatible: should be one of: >> + "qca,qca8334" >> + "qca,qca8337" >> + >> - #size-cells: must be 0 >> - #address-cells: must be 1 >> >> @@ -14,6 +17,20 @@ port and PHY id, each subnode describing a port needs to have a valid phandle >> referencing the internal PHY connected to it. The CPU port of this switch is >> always port 0. >> >> +A CPU port node has the following optional property: > > s/property/node/ > > Otherwise, > > Reviewed-by: Rob Herring <robh@kernel.org> Good catch, I will correct this. Thanks for the review Rob. Michal
On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > The CPU port default link settings can be reconfigured using > a fixed-link sub-node. > > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index 9c67ee4..15b9057 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -2,7 +2,10 @@ Required properties: -- compatible: should be "qca,qca8337" +- compatible: should be one of: + "qca,qca8334" + "qca,qca8337" + - #size-cells: must be 0 - #address-cells: must be 1 @@ -14,6 +17,20 @@ port and PHY id, each subnode describing a port needs to have a valid phandle referencing the internal PHY connected to it. The CPU port of this switch is always port 0. +A CPU port node has the following optional property: + +- fixed-link : Fixed-link subnode describing a link to a non-MDIO + managed entity. See + Documentation/devicetree/bindings/net/fixed-link.txt + for details. + +For QCA8K the 'fixed-link' sub-node supports only the following properties: + +- 'speed' (integer, mandatory), to indicate the link speed. Accepted + values are 10, 100 and 1000 +- 'full-duplex' (boolean, optional), to indicate that full duplex is + used. When absent, half duplex is assumed. + Example: @@ -53,6 +70,10 @@ Example: label = "cpu"; ethernet = <&gmac1>; phy-mode = "rgmii"; + fixed-link { + speed = 1000; + full-duplex; + }; }; port@1 {
Add support for the four-port variant of the Qualcomm QCA833x switch. The CPU port default link settings can be reconfigured using a fixed-link sub-node. Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> --- Changes in v2: - Add commit message and document fixed-link binding. .../devicetree/bindings/net/dsa/qca8k.txt | 23 +++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)