From patchwork Mon May 21 17:12:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: nevola X-Patchwork-Id: 917744 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tVstOm5z"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qQMT2sRvz9s2k for ; Tue, 22 May 2018 03:12:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbeEURMx (ORCPT ); Mon, 21 May 2018 13:12:53 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:33457 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbeEURMw (ORCPT ); Mon, 21 May 2018 13:12:52 -0400 Received: by mail-wr0-f173.google.com with SMTP id a15-v6so9442665wrm.0 for ; Mon, 21 May 2018 10:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=E997mPi31StLc4ftpY+0qRYyUWDARR48tk0mFH4AX1A=; b=tVstOm5z+OjU8g0b2jFvjF+UQuIxazqh9Rr7aS294ZtGY2m1wbooLJlfR4V5wlM7q9 s3W8oBMZZhNg723O89DxkBrQAw/RGe/L1wtx6HaDuHebQPOywZpglWbeWeYlPt9yXkse LSWVqCSIYdaXU3Yk47/QBvN7afhsSwADjLfEXY5OIYws9wqcApmEhsi8O5OXqq81996t lucv87EW9Q6rBxrr6A10m/6LSvJa42J8KmAsRKqLmIrU7Awr4dSADbgHjbABAGQfEVWR Qzfd7+cjen/Ds8MD56s0tX9MEL92deaYmZbw6Yddv9F6x79LYs/eHiINMg6GFvjKFkRq IqJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=E997mPi31StLc4ftpY+0qRYyUWDARR48tk0mFH4AX1A=; b=iiwZs9CznMT07OcDGnUQbVNvLE0l9Rd/5ZGgmDPccZ4QP8nYBBmq+cLI6fDdh6rrGQ +3vnESvvKTZIBvXgBKJtOBUJyKFQuzrzOl/RBHJlvJP1MG1S7FlCAfbBsmEt0sC2Zxob v8ebVKqFkDhdnZZ0PYfLhQI8o65iPkX127MobF8vDiQtQRjYlM6BQPQ97v9V54AxHPeS VFQC+ENQFC8DOIAQZy4dDEthAhy3ghajLn6Few4HmnuOBRTeBmLeaLMcDZL0d9CH5Hlw rrM6b/lJ0hIcFAQi4Ct/Z38YW3i2lGXi+PQDBdMJWFLGI8s+z+E13DDzGqd5cZAzHCVX t3Ag== X-Gm-Message-State: ALKqPwc+M+P8pbppcYpI0uiF9qVZ4++rxD/xx8+QWuQubggJ5SOee8De UTGT7ML3ZqCLrZ2sY0RKiI+ICQ== X-Google-Smtp-Source: AB8JxZqh6xz4IcwuJprwzukP9s4YKWrtbLcxoqZuwkoytNebkL5KJnwNqS3lR4NsTBESYpsmWdT+0g== X-Received: by 2002:adf:b201:: with SMTP id u1-v6mr17162890wra.2.1526922771026; Mon, 21 May 2018 10:12:51 -0700 (PDT) Received: from nevthink ([91.126.245.87]) by smtp.gmail.com with ESMTPSA id a14-v6sm20100949wra.84.2018.05.21.10.12.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 10:12:50 -0700 (PDT) Date: Mon, 21 May 2018 19:12:48 +0200 From: Laura Garcia Liebana To: netfilter-devel@vger.kernel.org Subject: [PATCH libmnl 3/3] examples: reduce LOCs during neigh attributes validation Message-ID: <20180521171248.avqmgsuytrfxm6cu@nevthink> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org This patch avoids some LOCs duplication. Signed-off-by: Laura Garcia Liebana --- examples/rtnl/rtnl-neigh-dump.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/examples/rtnl/rtnl-neigh-dump.c b/examples/rtnl/rtnl-neigh-dump.c index 54d87e5..f4d5000 100644 --- a/examples/rtnl/rtnl-neigh-dump.c +++ b/examples/rtnl/rtnl-neigh-dump.c @@ -22,11 +22,6 @@ static int data_attr_cb(const struct nlattr *attr, void *data) switch(type) { case NDA_DST: - if (mnl_attr_validate(attr, MNL_TYPE_BINARY) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } - break; case NDA_LLADDR: if (mnl_attr_validate(attr, MNL_TYPE_BINARY) < 0) { perror("mnl_attr_validate");