Patchwork Documentation: fix mdio-gpio name in booting-without-of.txt

login
register
mail settings
Submitter Paulius Zaleckas
Date Nov. 17, 2008, 2:32 p.m.
Message ID <20081117143238.8214.68389.stgit@Programuotojas.82-135-208-232.ip.zebra.lt>
Download mbox | patch
Permalink /patch/9173/
State Rejected
Headers show

Comments

Paulius Zaleckas - Nov. 17, 2008, 2:32 p.m.
Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
---

 Documentation/powerpc/booting-without-of.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Benjamin Herrenschmidt - Jan. 6, 2009, 11:40 p.m.
On Mon, 2008-11-17 at 16:32 +0200, Paulius Zaleckas wrote:
> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
> ---
> 
>  Documentation/powerpc/booting-without-of.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
> index 0ab0230..8670acc 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1822,7 +1822,7 @@ platforms are moved over to use the flattened-device-tree model.
>     g) MDIO on GPIOs
>  
>     Currently defined compatibles:
> -   - virtual,gpio-mdio
> +   - virtual,mdio-gpio

Except that the only occurence in the code seems to have it the 
other way round ...
Paulius Zaleckas - Jan. 19, 2009, 8:50 a.m.
Benjamin Herrenschmidt wrote:
> On Mon, 2008-11-17 at 16:32 +0200, Paulius Zaleckas wrote:
>> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
>> ---
>>
>>  Documentation/powerpc/booting-without-of.txt |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>
>> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
>> index 0ab0230..8670acc 100644
>> --- a/Documentation/powerpc/booting-without-of.txt
>> +++ b/Documentation/powerpc/booting-without-of.txt
>> @@ -1822,7 +1822,7 @@ platforms are moved over to use the flattened-device-tree model.
>>     g) MDIO on GPIOs
>>  
>>     Currently defined compatibles:
>> -   - virtual,gpio-mdio
>> +   - virtual,mdio-gpio
> 
> Except that the only occurence in the code seems to have it the 
> other way round ...

Where? The driver defines it as "virtual,mdio-gpio"
See drivers/net/phy/mdio-gpio.c:235

Patch

diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index 0ab0230..8670acc 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -1822,7 +1822,7 @@  platforms are moved over to use the flattened-device-tree model.
    g) MDIO on GPIOs
 
    Currently defined compatibles:
-   - virtual,gpio-mdio
+   - virtual,mdio-gpio
 
    MDC and MDIO lines connected to GPIO controllers are listed in the
    gpios property as described in section VIII.1 in the following order: