pwm: imx: Switch to SPDX identifier

Message ID 1526830815-15644-1-git-send-email-festevam@gmail.com
State New
Headers show
Series
  • pwm: imx: Switch to SPDX identifier
Related show

Commit Message

Fabio Estevam May 20, 2018, 3:40 p.m.
From: Fabio Estevam <fabio.estevam@nxp.com>

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/pwm/pwm-imx.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

Comments

Thierry Reding June 6, 2018, 9:09 a.m. | #1
On Sun, May 20, 2018 at 12:40:15PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/pwm/pwm-imx.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index 08cbe81..6ddd6fd 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -1,12 +1,8 @@
> -/*
> - * simple driver for PWM (Pulse Width Modulator) controller
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// simple driver for PWM (Pulse Width Modulator) controller
> +//
> +// Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>

Why do you replace the complete comment by C++ style? I thought only the
SPDX identifier was required to be in that style.

Thierry
Fabio Estevam June 6, 2018, 11:38 a.m. | #2
Hi Thierry,

On Wed, Jun 6, 2018 at 6:09 AM, Thierry Reding <thierry.reding@gmail.com> wrote:

> Why do you replace the complete comment by C++ style? I thought only the
> SPDX identifier was required to be in that style.

Putting everything as // is Linus Torvalds' preferred style:
https://lkml.org/lkml/2017/11/25/133

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 08cbe81..6ddd6fd 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -1,12 +1,8 @@ 
-/*
- * simple driver for PWM (Pulse Width Modulator) controller
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// simple driver for PWM (Pulse Width Modulator) controller
+//
+// Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
 
 #include <linux/module.h>
 #include <linux/kernel.h>