| Message ID | 20180519124431.16000-2-martin.blumenstingl@googlemail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | fix OOB size decoding on SK Hynix H27UCG8T2BTR | expand |
Hi Martin, On Sat, 19 May 2018 14:44:31 +0200, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > The datasheet of the H27UCG8T2BTR states that this chip has a page size > of "16,384 + 1,280(Spare) bytes". The description of the "4th Byte of > Device Identifier Description" indicates that bits 6, 3 and 2 are > encoding the "Redundant Area Size / 8KB", where 640 bytes is a value of > 0x6 (110 in binary notation). > > hynix_nand_extract_oobsize decodes an OOB size of 640 bytes for this > chip. Kernel boot log extract before this patch: > nand: Could not find valid ONFI parameter page; aborting > nand: device found, Manufacturer ID: 0xad, Chip ID: 0xde > nand: Hynix NAND 8GiB 3,3V 8-bit > nand: 8192 MiB, MLC, erase size: 4096 KiB, page size: 16384, > OOB size: 640 > > However, based on the description in the datasheet we need to multiply > the OOB size with 2, because it's "640 spare bytes per 8192 bytes page > size" and this NAND chip has a page size of 16384 (= 2 * 8192). After > this patch the kernel boot log reports: > nand: Could not find valid ONFI parameter page; aborting > nand: device found, Manufacturer ID: 0xad, Chip ID: 0xde > nand: Hynix NAND 8GiB 3,3V 8-bit > nand: 8192 MiB, MLC, erase size: 4096 KiB, page size: 16384, > OOB size: 1280 > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/mtd/nand/raw/nand_hynix.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/nand/raw/nand_hynix.c b/drivers/mtd/nand/raw/nand_hynix.c > index d542908a0ebb..60d9c54b769f 100644 > --- a/drivers/mtd/nand/raw/nand_hynix.c > +++ b/drivers/mtd/nand/raw/nand_hynix.c > @@ -473,6 +473,10 @@ static void hynix_nand_extract_oobsize(struct nand_chip *chip, > WARN(1, "Invalid OOB size"); > break; > } > + > + /* Reference: H27UCG8T2BTR - "Redundant Area Size / 8KB" */ > + if (mtd->writesize == SZ_16K) > + mtd->oobsize *= 2; As we're not entirely sure this is the case for all Hynix 16k pages NAND chips, would you mind narrowing the fix to only this reference? Something like the following: if (!strcmp("H27UCG8T2BTR", chip->parameters.model)) with a nice comment forward explaining why you do it. > } > } > Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/nand_hynix.c b/drivers/mtd/nand/raw/nand_hynix.c index d542908a0ebb..60d9c54b769f 100644 --- a/drivers/mtd/nand/raw/nand_hynix.c +++ b/drivers/mtd/nand/raw/nand_hynix.c @@ -473,6 +473,10 @@ static void hynix_nand_extract_oobsize(struct nand_chip *chip, WARN(1, "Invalid OOB size"); break; } + + /* Reference: H27UCG8T2BTR - "Redundant Area Size / 8KB" */ + if (mtd->writesize == SZ_16K) + mtd->oobsize *= 2; } }
The datasheet of the H27UCG8T2BTR states that this chip has a page size of "16,384 + 1,280(Spare) bytes". The description of the "4th Byte of Device Identifier Description" indicates that bits 6, 3 and 2 are encoding the "Redundant Area Size / 8KB", where 640 bytes is a value of 0x6 (110 in binary notation). hynix_nand_extract_oobsize decodes an OOB size of 640 bytes for this chip. Kernel boot log extract before this patch: nand: Could not find valid ONFI parameter page; aborting nand: device found, Manufacturer ID: 0xad, Chip ID: 0xde nand: Hynix NAND 8GiB 3,3V 8-bit nand: 8192 MiB, MLC, erase size: 4096 KiB, page size: 16384, OOB size: 640 However, based on the description in the datasheet we need to multiply the OOB size with 2, because it's "640 spare bytes per 8192 bytes page size" and this NAND chip has a page size of 16384 (= 2 * 8192). After this patch the kernel boot log reports: nand: Could not find valid ONFI parameter page; aborting nand: device found, Manufacturer ID: 0xad, Chip ID: 0xde nand: Hynix NAND 8GiB 3,3V 8-bit nand: 8192 MiB, MLC, erase size: 4096 KiB, page size: 16384, OOB size: 1280 Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/mtd/nand/raw/nand_hynix.c | 4 ++++ 1 file changed, 4 insertions(+)