Patchwork [U-Boot] S5PC2XX: GPIO Macro Values Corrected.

login
register
mail settings
Submitter Chander Kashyap
Date April 18, 2011, 4:53 a.m.
Message ID <1303102383-24476-1-git-send-email-chander.kashyap@linaro.org>
Download mbox | patch
Permalink /patch/91681/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Chander Kashyap - April 18, 2011, 4:53 a.m.
Macro values for Pull Up and Driver Strength were wrong.
Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/include/asm/arch-s5pc2xx/gpio.h |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

--
1.7.1
Minkyu Kang - April 18, 2011, 7:31 a.m.
Dear Chander Kashyap,

On 18 April 2011 13:53, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> Macro values for Pull Up and Driver Strength were wrong.
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
>  arch/arm/include/asm/arch-s5pc2xx/gpio.h |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-s5pc2xx/gpio.h b/arch/arm/include/asm/arch-s5pc2xx/gpio.h
> index 05e5b3e..38303e4 100644
> --- a/arch/arm/include/asm/arch-s5pc2xx/gpio.h
> +++ b/arch/arm/include/asm/arch-s5pc2xx/gpio.h

Please see "Sending updated patch versions" and please fix it.
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Thanks
Minkyu Kang

Patch

diff --git a/arch/arm/include/asm/arch-s5pc2xx/gpio.h b/arch/arm/include/asm/arch-s5pc2xx/gpio.h
index 05e5b3e..38303e4 100644
--- a/arch/arm/include/asm/arch-s5pc2xx/gpio.h
+++ b/arch/arm/include/asm/arch-s5pc2xx/gpio.h
@@ -99,14 +99,13 @@  void gpio_set_rate(struct s5p_gpio_bank *bank, int gpio, int mode);
 /* Pull mode */
 #define GPIO_PULL_NONE	0x0
 #define GPIO_PULL_DOWN	0x1
-#define GPIO_PULL_UP	0x2
+#define GPIO_PULL_UP	0x3

 /* Drive Strength level */
 #define GPIO_DRV_1X	0x0
-#define GPIO_DRV_2X	0x1
-#define GPIO_DRV_3X	0x2
+#define GPIO_DRV_3X	0x1
+#define GPIO_DRV_2X	0x2
 #define GPIO_DRV_4X	0x3
 #define GPIO_DRV_FAST	0x0
 #define GPIO_DRV_SLOW	0x1
-
 #endif