[GIT,PULL,2/5] memory: tegra: Changes for v4.18-rc1
mbox series

Message ID 20180518142245.20242-2-thierry.reding@gmail.com
State New
Headers show
Series
  • [GIT,PULL,1/5] dt-bindings: tegra: Changes for v4.18-rc1
Related show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory

Message

Thierry Reding May 18, 2018, 2:22 p.m. UTC
Hi ARM SoC maintainers,

The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

  Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory

for you to fetch changes up to bef89a8d81ca97aca864778746b110cf52847868:

  memory: tegra: Remove Tegra114 SATA and AFI reset definitions (2018-05-18 12:33:02 +0200)

Thanks,
Thierry

----------------------------------------------------------------
memory: tegra: Changes for v4.18-rc1

This contains some cleanup of the memory controller driver as well as
unification work to share more code between Tegra20 and later SoC
generations. Also included are an implementation for the hot resets
functionality by the memory controller which is required to properly
reset busy hardware.

----------------------------------------------------------------
Dmitry Osipenko (14):
      dt-bindings: memory: tegra: Add hot resets definitions
      memory: tegra: Do not handle spurious interrupts
      memory: tegra: Setup interrupts mask before requesting IRQ
      memory: tegra: Apply interrupts mask per SoC
      memory: tegra: Remove unused headers inclusions
      memory: tegra: Squash tegra20-mc into common tegra-mc driver
      memory: tegra: Introduce memory client hot reset
      memory: tegra: Add Tegra20 memory controller hot resets
      memory: tegra: Add Tegra30 memory controller hot resets
      memory: tegra: Add Tegra114 memory controller hot resets
      memory: tegra: Add Tegra124 memory controller hot resets
      memory: tegra: Register SMMU after MC driver became ready
      dt-bindings: memory: tegra: Remove Tegra114 SATA and AFI reset definitions
      memory: tegra: Remove Tegra114 SATA and AFI reset definitions

Thierry Reding (1):
      memory: tegra: Add Tegra210 memory controller hot resets

 drivers/memory/Kconfig                   |  10 -
 drivers/memory/Makefile                  |   1 -
 drivers/memory/tegra/Makefile            |   1 +
 drivers/memory/tegra/mc.c                | 362 +++++++++++++++++++++++++++----
 drivers/memory/tegra/mc.h                |  22 ++
 drivers/memory/tegra/tegra114.c          |  33 +++
 drivers/memory/tegra/tegra124.c          |  48 ++++
 drivers/memory/tegra/tegra20.c           | 296 +++++++++++++++++++++++++
 drivers/memory/tegra/tegra210.c          |  53 ++++-
 drivers/memory/tegra/tegra30.c           |  35 +++
 drivers/memory/tegra20-mc.c              | 254 ----------------------
 include/dt-bindings/memory/tegra114-mc.h |  17 ++
 include/dt-bindings/memory/tegra124-mc.h |  25 +++
 include/dt-bindings/memory/tegra20-mc.h  |  21 ++
 include/dt-bindings/memory/tegra210-mc.h |  31 +++
 include/dt-bindings/memory/tegra30-mc.h  |  19 ++
 include/soc/tegra/mc.h                   |  37 +++-
 17 files changed, 956 insertions(+), 309 deletions(-)
 create mode 100644 drivers/memory/tegra/tegra20.c
 delete mode 100644 drivers/memory/tegra20-mc.c
 create mode 100644 include/dt-bindings/memory/tegra20-mc.h

Comments

Thierry Reding May 18, 2018, 8:43 p.m. UTC | #1
On Fri, May 18, 2018 at 04:22:42PM +0200, Thierry Reding wrote:
> Hi ARM SoC maintainers,
> 
> The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
> 
>   Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory
> 
> for you to fetch changes up to bef89a8d81ca97aca864778746b110cf52847868:
> 
>   memory: tegra: Remove Tegra114 SATA and AFI reset definitions (2018-05-18 12:33:02 +0200)
> 
> Thanks,
> Thierry
> 
> ----------------------------------------------------------------
> memory: tegra: Changes for v4.18-rc1
> 
> This contains some cleanup of the memory controller driver as well as
> unification work to share more code between Tegra20 and later SoC
> generations. Also included are an implementation for the hot resets
> functionality by the memory controller which is required to properly
> reset busy hardware.
> 
> ----------------------------------------------------------------
> Dmitry Osipenko (14):
>       dt-bindings: memory: tegra: Add hot resets definitions
>       memory: tegra: Do not handle spurious interrupts
>       memory: tegra: Setup interrupts mask before requesting IRQ
>       memory: tegra: Apply interrupts mask per SoC
>       memory: tegra: Remove unused headers inclusions
>       memory: tegra: Squash tegra20-mc into common tegra-mc driver
>       memory: tegra: Introduce memory client hot reset
>       memory: tegra: Add Tegra20 memory controller hot resets
>       memory: tegra: Add Tegra30 memory controller hot resets
>       memory: tegra: Add Tegra114 memory controller hot resets
>       memory: tegra: Add Tegra124 memory controller hot resets
>       memory: tegra: Register SMMU after MC driver became ready
>       dt-bindings: memory: tegra: Remove Tegra114 SATA and AFI reset definitions
>       memory: tegra: Remove Tegra114 SATA and AFI reset definitions

Please don't pull this just yet. Dmitry just pointed out to me that the
final two patches here break bisectibility. I'll reorder them and will
send out a new pull request.

Thierry
Olof Johansson May 25, 2018, 12:11 p.m. UTC | #2
On Fri, May 18, 2018 at 04:22:42PM +0200, Thierry Reding wrote:
> Hi ARM SoC maintainers,
> 
> The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
> 
>   Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory
> 
> for you to fetch changes up to bef89a8d81ca97aca864778746b110cf52847868:
> 
>   memory: tegra: Remove Tegra114 SATA and AFI reset definitions (2018-05-18 12:33:02 +0200)
> 
> Thanks,
> Thierry
> 
> ----------------------------------------------------------------
> memory: tegra: Changes for v4.18-rc1
> 
> This contains some cleanup of the memory controller driver as well as
> unification work to share more code between Tegra20 and later SoC
> generations. Also included are an implementation for the hot resets
> functionality by the memory controller which is required to properly
> reset busy hardware.
> 
> ----------------------------------------------------------------
> Dmitry Osipenko (14):
>       dt-bindings: memory: tegra: Add hot resets definitions
>       memory: tegra: Do not handle spurious interrupts
>       memory: tegra: Setup interrupts mask before requesting IRQ
>       memory: tegra: Apply interrupts mask per SoC
>       memory: tegra: Remove unused headers inclusions
>       memory: tegra: Squash tegra20-mc into common tegra-mc driver
>       memory: tegra: Introduce memory client hot reset
>       memory: tegra: Add Tegra20 memory controller hot resets
>       memory: tegra: Add Tegra30 memory controller hot resets
>       memory: tegra: Add Tegra114 memory controller hot resets
>       memory: tegra: Add Tegra124 memory controller hot resets
>       memory: tegra: Register SMMU after MC driver became ready
>       dt-bindings: memory: tegra: Remove Tegra114 SATA and AFI reset definitions
>       memory: tegra: Remove Tegra114 SATA and AFI reset definitions
> 
> Thierry Reding (1):
>       memory: tegra: Add Tegra210 memory controller hot resets

Looks like this is just additional/proper resets, are there any backwards
compatibility concerns with older device trees or new assumptions of properties
that should be handled?


-Olof
Olof Johansson May 25, 2018, 12:13 p.m. UTC | #3
On Fri, May 18, 2018 at 10:43:51PM +0200, Thierry Reding wrote:
> On Fri, May 18, 2018 at 04:22:42PM +0200, Thierry Reding wrote:
> > Hi ARM SoC maintainers,
> > 
> > The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
> > 
> >   Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory
> > 
> > for you to fetch changes up to bef89a8d81ca97aca864778746b110cf52847868:
> > 
> >   memory: tegra: Remove Tegra114 SATA and AFI reset definitions (2018-05-18 12:33:02 +0200)
> > 
> > Thanks,
> > Thierry
> > 
> > ----------------------------------------------------------------
> > memory: tegra: Changes for v4.18-rc1
> > 
> > This contains some cleanup of the memory controller driver as well as
> > unification work to share more code between Tegra20 and later SoC
> > generations. Also included are an implementation for the hot resets
> > functionality by the memory controller which is required to properly
> > reset busy hardware.
> > 
> > ----------------------------------------------------------------
> > Dmitry Osipenko (14):
> >       dt-bindings: memory: tegra: Add hot resets definitions
> >       memory: tegra: Do not handle spurious interrupts
> >       memory: tegra: Setup interrupts mask before requesting IRQ
> >       memory: tegra: Apply interrupts mask per SoC
> >       memory: tegra: Remove unused headers inclusions
> >       memory: tegra: Squash tegra20-mc into common tegra-mc driver
> >       memory: tegra: Introduce memory client hot reset
> >       memory: tegra: Add Tegra20 memory controller hot resets
> >       memory: tegra: Add Tegra30 memory controller hot resets
> >       memory: tegra: Add Tegra114 memory controller hot resets
> >       memory: tegra: Add Tegra124 memory controller hot resets
> >       memory: tegra: Register SMMU after MC driver became ready
> >       dt-bindings: memory: tegra: Remove Tegra114 SATA and AFI reset definitions
> >       memory: tegra: Remove Tegra114 SATA and AFI reset definitions
> 
> Please don't pull this just yet. Dmitry just pointed out to me that the
> final two patches here break bisectibility. I'll reorder them and will
> send out a new pull request.

Please delete the tag when you withdraw a pull request, and do the next request
with a new tag name. That way I don't have to scan my mailbox to make sure all
pull requests are still valid when I go through it and won't accidentally merge
something that you have withdrawn.


-Olof
Dmitry Osipenko May 25, 2018, 12:45 p.m. UTC | #4
On 25.05.2018 15:11, Olof Johansson wrote:
> On Fri, May 18, 2018 at 04:22:42PM +0200, Thierry Reding wrote:
>> Hi ARM SoC maintainers,
>>
>> The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
>>
>>   Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
>>
>> are available in the Git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-4.18-memory
>>
>> for you to fetch changes up to bef89a8d81ca97aca864778746b110cf52847868:
>>
>>   memory: tegra: Remove Tegra114 SATA and AFI reset definitions (2018-05-18 12:33:02 +0200)
>>
>> Thanks,
>> Thierry
>>
>> ----------------------------------------------------------------
>> memory: tegra: Changes for v4.18-rc1
>>
>> This contains some cleanup of the memory controller driver as well as
>> unification work to share more code between Tegra20 and later SoC
>> generations. Also included are an implementation for the hot resets
>> functionality by the memory controller which is required to properly
>> reset busy hardware.
>>
>> ----------------------------------------------------------------
>> Dmitry Osipenko (14):
>>       dt-bindings: memory: tegra: Add hot resets definitions
>>       memory: tegra: Do not handle spurious interrupts
>>       memory: tegra: Setup interrupts mask before requesting IRQ
>>       memory: tegra: Apply interrupts mask per SoC
>>       memory: tegra: Remove unused headers inclusions
>>       memory: tegra: Squash tegra20-mc into common tegra-mc driver
>>       memory: tegra: Introduce memory client hot reset
>>       memory: tegra: Add Tegra20 memory controller hot resets
>>       memory: tegra: Add Tegra30 memory controller hot resets
>>       memory: tegra: Add Tegra114 memory controller hot resets
>>       memory: tegra: Add Tegra124 memory controller hot resets
>>       memory: tegra: Register SMMU after MC driver became ready
>>       dt-bindings: memory: tegra: Remove Tegra114 SATA and AFI reset definitions
>>       memory: tegra: Remove Tegra114 SATA and AFI reset definitions
>>
>> Thierry Reding (1):
>>       memory: tegra: Add Tegra210 memory controller hot resets
> 
> Looks like this is just additional/proper resets, are there any backwards
> compatibility concerns with older device trees or new assumptions of properties
> that should be handled?

Hello Olof,

AFAIK, memory resets never been used anywhere before. The device drivers would
have to take into account the backwards compatibility, like for example we do in
the proposed video-decoder patch that optionally utilizes the MC reset [0].

[0] https://patchwork.ozlabs.org/patch/917176/