| Message ID | 1526648700-15130-1-git-send-email-matthew.weber@rockwellcollins.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | support/scripts/pkg-stats: flake8 print() cleanup | expand |
Hello, On Friday, May 18, 2018 10:05:00 AM, Matt Weber wrote: > support/scripts/pkg-stats: flake8 print() cleanup AFAIK flake8 doesn't warn about this yet. Maybe this is a better title: support/scripts/pkg-stats: add parenthesis for print Also mentioning it is related to Python 3 in the commit log would be good: Use Python3-style "print". > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> If we want to support Python 2.6 for old distros this would also be needed: from __future__ import print_function But supporting old distros is important for scripts that run *during* the build process, so I think we don't need to do this in this case. [The commit title/message can be improved while applying; I assume we don't need to support Python 2.6 for this script, only for scripts that run during the build process.] Reviewed-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br> Regards, Ricardo
Hello, On Fri, 18 May 2018 08:05:00 -0500, Matt Weber wrote: > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > --- > support/scripts/pkg-stats | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Applied to next after adjusting the commit title and commit log as suggested by Ricardo. Thanks! Thomas
diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats index 43f7e8d..b7b00e8 100755 --- a/support/scripts/pkg-stats +++ b/support/scripts/pkg-stats @@ -499,17 +499,17 @@ def parse_args(): def __main__(): args = parse_args() if args.npackages and args.packages: - print "ERROR: -n and -p are mutually exclusive" + print("ERROR: -n and -p are mutually exclusive") sys.exit(1) if args.packages: package_list = args.packages.split(",") else: package_list = None - print "Build package list ..." + print("Build package list ...") packages = get_pkglist(args.npackages, package_list) - print "Getting package make info ..." + print("Getting package make info ...") package_init_make_info() - print "Getting package details ..." + print("Getting package details ...") for pkg in packages: pkg.set_infra() pkg.set_license() @@ -517,9 +517,9 @@ def __main__(): pkg.set_patch_count() pkg.set_check_package_warnings() pkg.set_current_version() - print "Calculate stats" + print("Calculate stats") stats = calculate_stats(packages) - print "Write HTML" + print("Write HTML") dump_html(packages, stats, args.output)
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> --- support/scripts/pkg-stats | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)