diff mbox series

[v2] i2c: rk3x: Don't print visible virtual mapping MMIO address

Message ID 1526604330-206516-1-git-send-email-shawn.lin@rock-chips.com
State Accepted
Headers show
Series [v2] i2c: rk3x: Don't print visible virtual mapping MMIO address | expand

Commit Message

Shawn Lin May 18, 2018, 12:45 a.m. UTC 
Now %p doesn't print visible pointer address unless the user
really want it. According to Documentation/core-api/printk-formats.rst,
%px should be used instead, otherwise we could see:

rk3x-i2c ff110000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
rk3x-i2c ff130000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
rk3x-i2c ff3c0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
rk3x-i2c ff3d0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)

But I don't really understand why we need dump it in the first place!
Let's remove the whole pointless log.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---

Changes in v2:
- remove the log as well suggested by Heiko

 drivers/i2c/busses/i2c-rk3x.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Wolfram Sang May 24, 2018, 8:10 p.m. UTC | #1 
On Fri, May 18, 2018 at 08:45:30AM +0800, Shawn Lin wrote:
> Now %p doesn't print visible pointer address unless the user
> really want it. According to Documentation/core-api/printk-formats.rst,
> %px should be used instead, otherwise we could see:
> 
> rk3x-i2c ff110000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
> rk3x-i2c ff130000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
> rk3x-i2c ff3c0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
> rk3x-i2c ff3d0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____)
> 
> But I don't really understand why we need dump it in the first place!
> Let's remove the whole pointless log.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index e1a18d9..b8a2728 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1326,8 +1326,6 @@  static int rk3x_i2c_probe(struct platform_device *pdev)
 	if (ret < 0)
 		goto err_clk_notifier;
 
-	dev_info(&pdev->dev, "Initialized RK3xxx I2C bus at %p\n", i2c->regs);
-
 	return 0;
 
 err_clk_notifier: