diff mbox series

[5/6] libflash/blocklevel_write: Fix missing error handling

Message ID 20180517233105.8243-6-bsingharora@gmail.com
State Accepted
Headers show
Series scan build fixes | expand

Commit Message

Balbir Singh May 17, 2018, 11:31 p.m. UTC 
Caught by scan-build, we seem to trap the errors in rc, but
not take any recovery action during blocklevel_write.

Signed-off-by: Balbir singh <bsingharora@gmail.com>
---
 libflash/blocklevel.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/libflash/blocklevel.c b/libflash/blocklevel.c
index f3fad69e..172f8fcc 100644
--- a/libflash/blocklevel.c
+++ b/libflash/blocklevel.c
@@ -263,6 +263,7 @@  int blocklevel_write(struct blocklevel_device *bl, uint64_t pos, const void *buf
 		if (rc) {
 			errno = EBADF;
 			rc = FLASH_ERR_ECC_INVALID;
+			goto out;
 		}
 
 		/*
@@ -274,6 +275,7 @@  int blocklevel_write(struct blocklevel_device *bl, uint64_t pos, const void *buf
 		if (rc) {
 			errno = EBADF;
 			rc = FLASH_ERR_ECC_INVALID;
+			goto out;
 		}
 
 		if (memcpy_to_ecc_unaligned(buffer, buf, len, ecc_diff)) {