| Message ID | 152659384481.2834.5040004714298449412.stgit@anamdev.jf.intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: Fix a bug in removing queues from XPS map | expand |
From: Amritha Nambiar <amritha.nambiar@intel.com> Date: Thu, 17 May 2018 14:50:44 -0700 > While removing queues from the XPS map, the individual CPU ID > alone was used to index the CPUs map, this should be changed to also > factor in the traffic class mapping for the CPU-to-queue lookup. > > Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes") > Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com> > Acked-by: Alexander Duyck <alexander.h.duyck@intel.com> Applied and queued up for -stable, thank you.
diff --git a/net/core/dev.c b/net/core/dev.c index 9f43901..9397577 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2125,7 +2125,7 @@ static bool remove_xps_queue_cpu(struct net_device *dev, int i, j; for (i = count, j = offset; i--; j++) { - if (!remove_xps_queue(dev_maps, cpu, j)) + if (!remove_xps_queue(dev_maps, tci, j)) break; }
While removing queues from the XPS map, the individual CPU ID alone was used to index the CPUs map, this should be changed to also factor in the traffic class mapping for the CPU-to-queue lookup. Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes") Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com> Acked-by: Alexander Duyck <alexander.h.duyck@intel.com> --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)