| Message ID | 20180517154330.10678-1-dsahern@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: NET_VENDOR_MICROSEMI should default ot N | expand |
On 05/17/2018 06:43 PM, David Ahern wrote: > Other ethernet drivers default to N. There is no reason for Microsemi > to default to y. I believe Linus has set the bar at a feature that cures > cancer can be enabled by default. [1] > > [1] https://lkml.org/lkml/2010/3/2/366 > > Signed-off-by: David Ahern <dsahern@gmail.com> > --- > drivers/net/ethernet/mscc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig > index 36c84625d54e..0ef40b05c8af 100644 > --- a/drivers/net/ethernet/mscc/Kconfig > +++ b/drivers/net/ethernet/mscc/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0 OR MIT) > config NET_VENDOR_MICROSEMI > bool "Microsemi devices" > - default y > + default n You know that N is the default default? :-) [...] MBR, Sergei
From: David Ahern <dsahern@gmail.com> Date: Thu, 17 May 2018 08:43:30 -0700 > Other ethernet drivers default to N. There is no reason for Microsemi > to default to y. I believe Linus has set the bar at a feature that cures > cancer can be enabled by default. [1] > > [1] https://lkml.org/lkml/2010/3/2/366 > > Signed-off-by: David Ahern <dsahern@gmail.com> For "drivers" yes, those should default to N. But for vendor guards like this, they should default to Y.
diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig index 36c84625d54e..0ef40b05c8af 100644 --- a/drivers/net/ethernet/mscc/Kconfig +++ b/drivers/net/ethernet/mscc/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR MIT) config NET_VENDOR_MICROSEMI bool "Microsemi devices" - default y + default n help If you have a network (Ethernet) card belonging to this class, say Y.
Other ethernet drivers default to N. There is no reason for Microsemi to default to y. I believe Linus has set the bar at a feature that cures cancer can be enabled by default. [1] [1] https://lkml.org/lkml/2010/3/2/366 Signed-off-by: David Ahern <dsahern@gmail.com> --- drivers/net/ethernet/mscc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)