[U-Boot,v2] net: MVGBE don't automatically select PHYLIB

Message ID 20180517121204.7862-1-judge.packham@gmail.com
State Awaiting Upstream
Delegated to: Stefan Roese
Headers show
Series
  • [U-Boot,v2] net: MVGBE don't automatically select PHYLIB
Related show

Commit Message

Chris Packham May 17, 2018, 12:12 p.m.
When Kconfig support was added for MVGBE it included automatically
selected PHYLIB support. But MVGBE does not need PHYLIB it will build
fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
should have been a no-op in terms of build size but because of the
selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have
already enabled it in their config header file.

Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

Changes in v2:
- reword commit message to make the intent a bit clearer

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini May 17, 2018, 2:14 p.m. | #1
On Fri, May 18, 2018 at 12:12:04AM +1200, Chris Packham wrote:

> When Kconfig support was added for MVGBE it included automatically
> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> should have been a no-op in terms of build size but because of the
> selecting PHYLIB the openrd configs increased in size.
> 
> Remove the automatic selection of PHYLIB, boards that need it will have
> already enabled it in their config header file.
> 
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Joe Hershberger May 17, 2018, 3:30 p.m. | #2
On Thu, May 17, 2018 at 7:12 AM, Chris Packham <judge.packham@gmail.com> wrote:
> When Kconfig support was added for MVGBE it included automatically
> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> should have been a no-op in terms of build size but because of the
> selecting PHYLIB the openrd configs increased in size.
>
> Remove the automatic selection of PHYLIB, boards that need it will have
> already enabled it in their config header file.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Stefan, feel free to pull this through your branch.

Cheers,
-Joe
Stefan Roese May 17, 2018, 3:32 p.m. | #3
On 17.05.2018 17:30, Joe Hershberger wrote:
> On Thu, May 17, 2018 at 7:12 AM, Chris Packham <judge.packham@gmail.com> wrote:
>> When Kconfig support was added for MVGBE it included automatically
>> selected PHYLIB support. But MVGBE does not need PHYLIB it will build
>> fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE")
>> should have been a no-op in terms of build size but because of the
>> selecting PHYLIB the openrd configs increased in size.
>>
>> Remove the automatic selection of PHYLIB, boards that need it will have
>> already enabled it in their config header file.
>>
>> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> Stefan, feel free to pull this through your branch.

Thanks, will do.

Thanks,
Stefan

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index c962d7a72c0c..f2cc75f494e8 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -181,7 +181,6 @@  config FTMAC100
 config MVGBE
 	bool "Marvell Orion5x/Kirkwood network interface support"
 	depends on KIRKWOOD || ORION5X
-	select PHYLIB
 	help
 	  This driver supports the network interface units in the
 	  Marvell Orion5x and Kirkwood SoCs