mtd: spi-nor: Add support for EN25QH32

Message ID 1526524827-30380-1-git-send-email-tochiro.srchack@gmail.com
State Accepted
Delegated to: Cyrille Pitchen
Headers show
Series
  • mtd: spi-nor: Add support for EN25QH32
Related show

Commit Message

ļ¼ SRCHACK.ORG May 17, 2018, 2:40 a.m.
Add support for Eon en25qh32 spi nor flash.

Sorry, very sorry.
I had misspelled it. chip name is en25qh32, non en25ph32.

Signed-off-by: YuheiOKAWA <tochiro.srchack@gmail.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Boris Brezillon May 18, 2018, 8:08 p.m. | #1
On Thu, 17 May 2018 11:40:27 +0900
YuheiOKAWA <tochiro.srchack@gmail.com> wrote:

> Add support for Eon en25qh32 spi nor flash.
> 
> Sorry, very sorry.
> I had misspelled it. chip name is en25qh32, non en25ph32.

Queued to spi-nor/next after removing this sentence :-).

Next time you want to add extra information that you don't want
to appear in the commit, just put it after the "---" separator ;-).

Also, you should prefix your patch with "[PATCH v2]" and add a
changelog after the "---". Something like:

"
---
Changes in v2:
- blablabla
"

Thanks,

Boris

> 
> Signed-off-by: YuheiOKAWA <tochiro.srchack@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 5bfa36e..7bc556c 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -980,6 +980,7 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
>  	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
>  	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
> +	{ "en25qh32",   INFO(0x1c7016, 0, 64 * 1024,   64, 0) },
>  	{ "en25qh128",  INFO(0x1c7018, 0, 64 * 1024,  256, 0) },
>  	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
>  	{ "en25s64",	INFO(0x1c3817, 0, 64 * 1024,  128, SECT_4K) },
ļ¼ SRCHACK.ORG May 19, 2018, 1:33 p.m. | #2
Dear, Boris

Thanks,
Yes, I will.


On 2018/05/19 5:08, Boris Brezillon wrote:
> On Thu, 17 May 2018 11:40:27 +0900
> YuheiOKAWA <tochiro.srchack@gmail.com> wrote:
> 
>> Add support for Eon en25qh32 spi nor flash.
>>
>> Sorry, very sorry.
>> I had misspelled it. chip name is en25qh32, non en25ph32.
> 
> Queued to spi-nor/next after removing this sentence :-).
> 
> Next time you want to add extra information that you don't want
> to appear in the commit, just put it after the "---" separator ;-).
> 
> Also, you should prefix your patch with "[PATCH v2]" and add a
> changelog after the "---". Something like:
> 
> "
> ---
> Changes in v2:
> - blablabla
> "
> 
> Thanks,
> 
> Boris
> 
>>
>> Signed-off-by: YuheiOKAWA <tochiro.srchack@gmail.com>
>> ---
>>   drivers/mtd/spi-nor/spi-nor.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 5bfa36e..7bc556c 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -980,6 +980,7 @@ static const struct flash_info spi_nor_ids[] = {
>>   	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
>>   	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
>>   	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
>> +	{ "en25qh32",   INFO(0x1c7016, 0, 64 * 1024,   64, 0) },
>>   	{ "en25qh128",  INFO(0x1c7018, 0, 64 * 1024,  256, 0) },
>>   	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
>>   	{ "en25s64",	INFO(0x1c3817, 0, 64 * 1024,  128, SECT_4K) },
> 
>

Patch

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 5bfa36e..7bc556c 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -980,6 +980,7 @@  static const struct flash_info spi_nor_ids[] = {
 	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
 	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
 	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
+	{ "en25qh32",   INFO(0x1c7016, 0, 64 * 1024,   64, 0) },
 	{ "en25qh128",  INFO(0x1c7018, 0, 64 * 1024,  256, 0) },
 	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
 	{ "en25s64",	INFO(0x1c3817, 0, 64 * 1024,  128, SECT_4K) },