Patchwork [pph] Initialize fields in default ctor for _Hashtable_iterator (issue4430051)

login
register
mail settings
Submitter Diego Novillo
Date April 16, 2011, 8:30 p.m.
Message ID <20110416203023.575C1AE18B@tobiano.tor.corp.google.com>
Download mbox | patch
Permalink /patch/91500/
State New
Headers show

Comments

Diego Novillo - April 16, 2011, 8:30 p.m.
I am committing this patch for David Li on google/main.

The patch adds explicit initialization to the fields of
_Hashtable_iterator in its default constructor.  David, could you
describe why this change was needed?  Will you be submitting for
trunk?

Tested on x86_64.  Committed to google/main.


Diego.

2011-04-15  Xinliang David Li  <davidxl@google.com>
    
    	Google ref 43787.
    
    	* include/backward/hashtable.h
    	(_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and
    	_M_ht in default constructor.


--
This patch is available for review at http://codereview.appspot.com/4430051
Diego Novillo - April 16, 2011, 8:42 p.m.
Geez, working on too many different branches.  This is *not* a pph patch.

On Sat, Apr 16, 2011 at 16:30, Diego Novillo <dnovillo@google.com> wrote:
> I am committing this patch for David Li on google/main.
>
> The patch adds explicit initialization to the fields of
> _Hashtable_iterator in its default constructor.  David, could you
> describe why this change was needed?  Will you be submitting for
> trunk?
>
> Tested on x86_64.  Committed to google/main.
>
>
> Diego.
>
> 2011-04-15  Xinliang David Li  <davidxl@google.com>
>
>        Google ref 43787.
>
>        * include/backward/hashtable.h
>        (_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and
>        _M_ht in default constructor.
>
> diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h
> index 0bcaec4..c3eefcc 100644
> --- a/libstdc++-v3/include/backward/hashtable.h
> +++ b/libstdc++-v3/include/backward/hashtable.h
> @@ -126,7 +126,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>       _Hashtable_iterator(_Node* __n, _Hashtable* __tab)
>       : _M_cur(__n), _M_ht(__tab) { }
>
> -      _Hashtable_iterator() { }
> +      _Hashtable_iterator()
> +      : _M_cur(0), _M_ht(0) { }
>
>       reference
>       operator*() const
>
> --
> This patch is available for review at http://codereview.appspot.com/4430051
>

Patch

diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h
index 0bcaec4..c3eefcc 100644
--- a/libstdc++-v3/include/backward/hashtable.h
+++ b/libstdc++-v3/include/backward/hashtable.h
@@ -126,7 +126,8 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
       _Hashtable_iterator(_Node* __n, _Hashtable* __tab)
       : _M_cur(__n), _M_ht(__tab) { }
 
-      _Hashtable_iterator() { }
+      _Hashtable_iterator()
+      : _M_cur(0), _M_ht(0) { }
 
       reference
       operator*() const