| Message ID | 20110416203023.575C1AE18B@tobiano.tor.corp.google.com |
|---|---|
| State | New |
| Headers | show |
Geez, working on too many different branches. This is *not* a pph patch. On Sat, Apr 16, 2011 at 16:30, Diego Novillo <dnovillo@google.com> wrote: > I am committing this patch for David Li on google/main. > > The patch adds explicit initialization to the fields of > _Hashtable_iterator in its default constructor. David, could you > describe why this change was needed? Will you be submitting for > trunk? > > Tested on x86_64. Committed to google/main. > > > Diego. > > 2011-04-15 Xinliang David Li <davidxl@google.com> > > Google ref 43787. > > * include/backward/hashtable.h > (_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and > _M_ht in default constructor. > > diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h > index 0bcaec4..c3eefcc 100644 > --- a/libstdc++-v3/include/backward/hashtable.h > +++ b/libstdc++-v3/include/backward/hashtable.h > @@ -126,7 +126,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > _Hashtable_iterator(_Node* __n, _Hashtable* __tab) > : _M_cur(__n), _M_ht(__tab) { } > > - _Hashtable_iterator() { } > + _Hashtable_iterator() > + : _M_cur(0), _M_ht(0) { } > > reference > operator*() const > > -- > This patch is available for review at http://codereview.appspot.com/4430051 >
diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h index 0bcaec4..c3eefcc 100644 --- a/libstdc++-v3/include/backward/hashtable.h +++ b/libstdc++-v3/include/backward/hashtable.h @@ -126,7 +126,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _Hashtable_iterator(_Node* __n, _Hashtable* __tab) : _M_cur(__n), _M_ht(__tab) { } - _Hashtable_iterator() { } + _Hashtable_iterator() + : _M_cur(0), _M_ht(0) { } reference operator*() const
I am committing this patch for David Li on google/main. The patch adds explicit initialization to the fields of _Hashtable_iterator in its default constructor. David, could you describe why this change was needed? Will you be submitting for trunk? Tested on x86_64. Committed to google/main. Diego. 2011-04-15 Xinliang David Li <davidxl@google.com> Google ref 43787. * include/backward/hashtable.h (_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and _M_ht in default constructor. -- This patch is available for review at http://codereview.appspot.com/4430051