[2/3] ibmvnic: Fix non-fatal firmware error reset

Message ID 1526503745-14421-3-git-send-email-tlfalcon@linux.vnet.ibm.com
State Accepted
Delegated to: David Miller
Headers show
  • ibmvnic: Fix bugs and memory leaks
Related show

Commit Message

Thomas Falcon May 16, 2018, 8:49 p.m.
It is not necessary to disable interrupt lines here during a reset
to handle a non-fatal firmware error. Move that call within the code
block that handles the other cases that do require interrupts to be
disabled and re-enabled.

Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
 drivers/net/ethernet/ibm/ibmvnic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 9e08917..1b9c22f 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1822,9 +1822,8 @@  static int do_reset(struct ibmvnic_adapter *adapter,
 			if (rc)
 				return rc;
+		ibmvnic_disable_irqs(adapter);
-	ibmvnic_disable_irqs(adapter);
 	adapter->state = VNIC_CLOSED;
 	if (reset_state == VNIC_CLOSED)