From patchwork Wed May 16 18:51:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 914886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D1f8kny/"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40mPLx29pSz9s0y for ; Thu, 17 May 2018 05:16:57 +1000 (AEST) Received: from localhost ([::1]:34323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1uw-000619-Qx for incoming@patchwork.ozlabs.org; Wed, 16 May 2018 15:16:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1XT-0003Xs-VV for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJ1XS-0000zP-VB for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:40 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:56292) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJ1XS-0000yj-OS for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:38 -0400 Received: by mail-wm0-x241.google.com with SMTP id a8-v6so3853313wmg.5 for ; Wed, 16 May 2018 11:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x2W86L4tbwIbNvTHX37twLgmG4CdFXAYimAqFjGgfA8=; b=D1f8kny/uZVISqETbqhpuuyC5DU7DmV9VuN+3cCYFU/qS3QuGOcC3yoVS6HIVYfBVk iWXFMWj8OOZX8IhKPIUlIF/fDiTjB8paSPQF8fnuSrIJyGVFiXEbQreiTLBwdKVFNedO 7CMD17bWesnm/6dsM44/gI1470+iNWWGiC7sB0/qCCoJ59g7+ejaTy2ZU3duXx2w+01v RQdm92m0BTJ+475bdnCsz2lG89r5pb9TeT3qCL0xwM4NPovP0oW0KsM0KI/yjnIEIScD dpmTk51nrQms5IV+1pFW97F1YhL8IXLTv4CWvqo2F/GQCzN0VUpqdHtCaV1MRmz8/LWL lT/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x2W86L4tbwIbNvTHX37twLgmG4CdFXAYimAqFjGgfA8=; b=JzQJLeXDB2hbvhuMhDk+vmHbGg4mfmdeeTDNAuRqHXyE3qTOTE096SY68yOa497bbi tL/1tHLocGUYPDeKo1cAEKCo6IA65o9UKTqs061JUKeQ1VvT33GUlRNm9KhQPwPX3CSC crL9ZxMF6n5vwmTdxnohyx6lSPGOaJ/lQaCpxJFl4PowG6OpBlS7kxuybVYMdJ9keNez rOq+ALlImXMzaIw8jKKboGxOe9pjBUb6OBKjExX7ihsWt5gqcQaKvReV28VCsrGLyA4I QSH2FywOjwowy+Vdysh/5g3aUNz0bsyxrhUT4icJ50Ge+PP7IN0ARiFj0/c/FF7xCgcp 27Ww== X-Gm-Message-State: ALKqPwd/agW5PqqrhB6Lwt1MmHmYvgHqj2XkHl2o10U9f0TbbpzMhMPV OBJEHgx1h2HtVwUDRn5Z780DCg== X-Google-Smtp-Source: AB8JxZrVrSuSS/9Z6I9trMoBEZaiUX5eYtZR0F1BdGGm3vWlJXMlM9VWWHuGyWMFpvSsIzyC7A5Hqg== X-Received: by 2002:a2e:8595:: with SMTP id b21-v6mr1210921lji.131.1526496757386; Wed, 16 May 2018 11:52:37 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id p18-v6sm566716lfd.91.2018.05.16.11.52.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 11:52:36 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Wed, 16 May 2018 20:51:39 +0200 Message-Id: <20180516185146.30708-32-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180516185146.30708-1-edgar.iglesias@gmail.com> References: <20180516185146.30708-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH v3 31/38] target-microblaze: Simplify address computation using tcg_gen_addi_i32() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sstabellini@kernel.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Edgar E. Iglesias" Simplify address computation using tcg_gen_addi_i32(). tcg_gen_addi_i32() already optimizes the case when the immediate is zero. No functional change. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé --- target/microblaze/translate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 39c4d0654e..44395cf189 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -899,12 +899,7 @@ static inline void compute_ldst_addr(DisasContext *dc, bool ea, TCGv t) /* Immediate. */ t32 = tcg_temp_new_i32(); if (!extimm) { - if (dc->imm == 0) { - tcg_gen_mov_i32(t32, cpu_R[dc->ra]); - } else { - tcg_gen_movi_i32(t32, (int32_t)((int16_t)dc->imm)); - tcg_gen_add_i32(t32, cpu_R[dc->ra], t32); - } + tcg_gen_addi_i32(t32, cpu_R[dc->ra], (int16_t)dc->imm); } else { tcg_gen_add_i32(t32, cpu_R[dc->ra], *(dec_alu_op_b(dc))); }