From patchwork Wed May 16 18:51:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 914881 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nd//K9Vb"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40mPGj1ynwz9s1B for ; Thu, 17 May 2018 05:13:17 +1000 (AEST) Received: from localhost ([::1]:34293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1rO-000394-QC for incoming@patchwork.ozlabs.org; Wed, 16 May 2018 15:13:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1X2-00037w-Cs for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJ1Wz-0000kj-91 for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:12 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJ1Wz-0000kd-23 for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:09 -0400 Received: by mail-wr0-x241.google.com with SMTP id i14-v6so2775990wre.2 for ; Wed, 16 May 2018 11:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dubDq29PlfqBXN67YbJvlOLf7EEssv8YsHI8xmDwUFc=; b=nd//K9VbCcX1gSWAMVsdCDvBtCz9RMCsJ0Fzcbk00iGS0Dux3uOVzlJHgcRdVe6t1i LeOgWtbIEruK6eeaXJXHA57rfMjSpVQXyg3Jqs+G3ZzUJFEsyLX7vwVeMQLoxeOtTgUU r4BAuAAtOG3SQLvoZPhUN9bKg7xuLcRybL7BMCdNZarkmSsvPY5pYQr4QS/OXMYWumw8 BNe0K3Kn8McMv75V2Xlq8Ulbc6mLmbhXG9d7O6kSE8xRww4+I29uRlYH5ED7Rqyhyf8A yYt+7Qi96AHEuVfFpwPSv7v1ZmedH/4eFXpPM5mVnWAC3jdvSt+/eXsYdXeFznRpRKxt c81g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dubDq29PlfqBXN67YbJvlOLf7EEssv8YsHI8xmDwUFc=; b=RzUVu3W5gliXBIeXKlr9T2IVN2wLT9wsu+vLtQRGhSO6piWY53uffG+NPN64O8mPDB OTGZCpdC3Ggfh4M2Ec++b66diAyvy/yLNyEvl3R+/vcGoA8z6gGIIphHdbzUnDyno/7a lGbYwI1MxeUlLyY+AFFGC2ePedyrjC5DmVJ1mcXq+xHc1eW248R3FwVaXfRQxB1sYUCv IPiNf3At84X0ULFM2jaINFeT6Xvu8JTSpfmlR5xnkWqO9IzpwaMMzseRrmzLeIVFd1eT harvHXX2ONEYNnBApnaWCdfLHiekCgNO09z+NDoWWMcaqRBswPCfQA0UHj42GEaIaTDJ jy5g== X-Gm-Message-State: ALKqPwdZV+zAvOnL+lsQDREaQdeI6TfpxhQNezLzHL/DpPONSFDUPunw X1mbKxMCjvQ/Jl8hhzlp0K73Xg== X-Google-Smtp-Source: AB8JxZp8aT+ZZ7xXsd2xJzUOSibif2S86dkL4C4gDBPNR6xHp566uuuagzEGEjjrNUi/0NwBsSgr3w== X-Received: by 2002:a19:db0c:: with SMTP id s12-v6mr12140164lfg.109.1526496727567; Wed, 16 May 2018 11:52:07 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id o11-v6sm519343ljc.77.2018.05.16.11.52.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 11:52:06 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Wed, 16 May 2018 20:51:20 +0200 Message-Id: <20180516185146.30708-13-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180516185146.30708-1-edgar.iglesias@gmail.com> References: <20180516185146.30708-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH v3 12/38] target-microblaze: Remove pointer indirection for ld/st addresses X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sstabellini@kernel.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Edgar E. Iglesias" Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 3431a07b99..5ef978e897 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -848,7 +848,7 @@ static void dec_imm(DisasContext *dc) dc->clear_imm = 0; } -static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) +static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 t) { bool extimm = dc->tb_flags & IMM_FLAG; /* Should be set to true if r1 is used by loadstores. */ @@ -863,10 +863,10 @@ static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) if (!dc->type_b) { /* If any of the regs is r0, return the value of the other reg. */ if (dc->ra == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->rb]); + tcg_gen_mov_i32(t, cpu_R[dc->rb]); return; } else if (dc->rb == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->ra]); + tcg_gen_mov_i32(t, cpu_R[dc->ra]); return; } @@ -874,27 +874,27 @@ static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) stackprot = true; } - tcg_gen_add_i32(*t, cpu_R[dc->ra], cpu_R[dc->rb]); + tcg_gen_add_i32(t, cpu_R[dc->ra], cpu_R[dc->rb]); if (stackprot) { - gen_helper_stackprot(cpu_env, *t); + gen_helper_stackprot(cpu_env, t); } return; } /* Immediate. */ if (!extimm) { if (dc->imm == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->ra]); + tcg_gen_mov_i32(t, cpu_R[dc->ra]); return; } - tcg_gen_movi_i32(*t, (int32_t)((int16_t)dc->imm)); - tcg_gen_add_i32(*t, cpu_R[dc->ra], *t); + tcg_gen_movi_i32(t, (int32_t)((int16_t)dc->imm)); + tcg_gen_add_i32(t, cpu_R[dc->ra], t); } else { - tcg_gen_add_i32(*t, cpu_R[dc->ra], *(dec_alu_op_b(dc))); + tcg_gen_add_i32(t, cpu_R[dc->ra], *(dec_alu_op_b(dc))); } if (stackprot) { - gen_helper_stackprot(cpu_env, *t); + gen_helper_stackprot(cpu_env, t); } return; } @@ -929,7 +929,7 @@ static void dec_load(DisasContext *dc) t_sync_flags(dc); addr = tcg_temp_new_i32(); - compute_ldst_addr(dc, &addr); + compute_ldst_addr(dc, addr); /* * When doing reverse accesses we need to do two things. @@ -1041,7 +1041,7 @@ static void dec_store(DisasContext *dc) sync_jmpstate(dc); /* SWX needs a temp_local. */ addr = ex ? tcg_temp_local_new_i32() : tcg_temp_new_i32(); - compute_ldst_addr(dc, &addr); + compute_ldst_addr(dc, addr); if (ex) { /* swx */ TCGv_i32 tval;