From patchwork Wed May 16 15:42:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 914728 X-Patchwork-Delegate: agraf@suse.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="AbtcVOFj"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40mJtD3x4pz9s2R for ; Thu, 17 May 2018 01:55:16 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 14F4AC22014; Wed, 16 May 2018 15:48:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 68B5FC21FEE; Wed, 16 May 2018 15:44:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F1ADAC21FEA; Wed, 16 May 2018 15:43:08 +0000 (UTC) Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by lists.denx.de (Postfix) with ESMTPS id D0B58C21FD8 for ; Wed, 16 May 2018 15:43:01 +0000 (UTC) Received: by mail-it0-f68.google.com with SMTP id y189-v6so3019216itb.2 for ; Wed, 16 May 2018 08:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=WqtW92RtUrSAcE/u6Z4bH31XBFc1oVO0cZFV6rZplaE=; b=AbtcVOFjzIj1Xl5Z8TFy8z26/2//1/D0BJws1oZ7V+vBSmx55jYFYMFJE/tWnEQUQI 0m0ATVgpf8wSPx/5c4qnsSmhP17QLXhm1CP+TI6gJsLf/qwAzrS+Lu5aJZ+3gHX2ZFCT K0PNnm0Rl9u+YVc/Y+mB0Z8bhfRitt+AIOWbVFMlCxUEKOcI7qPSGMeFPp1KfOTwzArL 5oRsTaq2eQFHgPmFv6hoDXnzE1sksTUrMc5fVdv2JlM0ys/CpTJ+eGzPsp4uLunnGp5S J0nVq3XhydjAoW0buJNzYQVeus6Al96QZ6VnYaVarKABkot7MUgXgt7BkGclIyHEss1n D7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=WqtW92RtUrSAcE/u6Z4bH31XBFc1oVO0cZFV6rZplaE=; b=gesgv40v7XCRcxH6cWTVBbUJEYEN/02RgBciJUsEGRvfs+Lmfr72Mp0Wuk0MsH6OY8 wMJ0A3nnEekJxSndCDi5yrD48hBssLW5qOQvnJ32V4RegcI9kzmbxi5f0O8ZtPoRbgNf Sg/61mLrdQRy6kQhCiM14GsHVvkPaEuMMau5YSY+b13lx4jbDeQF3PAjtGqcfufTGALl 7OcWX0gNouMT7GjzYLmFH1rm9ks9magaosgQiPSb28e1vwNibfzm7HdHVIym+Vcswo65 9daBPr+PUScTTe1RrJiS5etrptnMGqKouzN4guEGh5CR78BHQuvwCzN6XDMimi5hwtA3 zj5A== X-Gm-Message-State: ALKqPwfuszZuvP3IsPtWSkbjZsc6c7ovrUj7L1LwBe4GK7/DUFW58fbX N74GlEzB32cCDbnMiTrggOFjPg== X-Google-Smtp-Source: AB8JxZqLdbzUrdqEY4DbUPUjxxItxcwAZqf8J/jYqDmNL2GywDln/b57IAycEtyfJm5eL67431kHdA== X-Received: by 2002:a6b:ad8d:: with SMTP id m13-v6mr1602843ioo.52.1526485380222; Wed, 16 May 2018 08:43:00 -0700 (PDT) Received: from kiwi.bld.corp.google.com ([100.67.80.24]) by smtp.gmail.com with ESMTPSA id i11-v6sm1790895itb.38.2018.05.16.08.42.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 08:42:59 -0700 (PDT) Received: by kiwi.bld.corp.google.com (Postfix, from userid 121222) id 0C7CE140208; Wed, 16 May 2018 09:42:59 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Wed, 16 May 2018 09:42:28 -0600 Message-Id: <20180516154233.21457-12-sjg@chromium.org> X-Mailer: git-send-email 2.17.0.441.gb46fe60e1d-goog In-Reply-To: <20180516154233.21457-1-sjg@chromium.org> References: <20180516154233.21457-1-sjg@chromium.org> Cc: Andy Shevchenko , Heinrich Schuchardt , Alexander Graf Subject: [U-Boot] [PATCH v4 11/16] efi: Add a comment about duplicated ELF constants X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" These constants are defined in arch-specific code but redefined here. Add a TODO to clean this up. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v4: None Changes in v3: None Changes in v2: None lib/efi_loader/efi_runtime.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index ac02f64d967..e94b94389d8 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c @@ -36,6 +36,10 @@ static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void); #define EFI_CACHELINE_SIZE 128 #endif +/* + * TODO(sjg@chromium.org): These defines and structs should come from the elf. + * header for each arch (or a generic header) rather than being repeated here. + */ #if defined(CONFIG_ARM64) #define R_RELATIVE 1027 #define R_MASK 0xffffffffULL