diff mbox

powerpc: Fix kexec-related UP build error

Message ID 20110415202916.GA6758@linux.vnet.ibm.com (mailing list archive)
State Rejected
Headers show

Commit Message

Paul E. McKenney April 15, 2011, 8:29 p.m. UTC 
Hello!

The following patch fixes a UP build problem for kexec() on powerpc.
When the crash_kexec_wait_realmode() function was added, it was
placed in only two of the three required locations.

Thoughts?

							Thanx, Paul

------------------------------------------------------------------------

The function crash_kexec_wait_realmode() is defined only if SMP, but is
called in UP builds.  Create an empty function to keep the compiler happy
in UP builds.

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Comments

Nishanth Aravamudan April 15, 2011, 9 p.m. UTC | #1 
Hi Paul,

On 15.04.2011 [13:29:16 -0700], Paul E. McKenney wrote:
> Hello!
> 
> The following patch fixes a UP build problem for kexec() on powerpc.
> When the crash_kexec_wait_realmode() function was added, it was
> placed in only two of the three required locations.

I believe the fix has already been posted as

http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html

Thanks,
Nish
Paul E. McKenney April 15, 2011, 9:08 p.m. UTC | #2 
On Fri, Apr 15, 2011 at 02:00:51PM -0700, Nishanth Aravamudan wrote:
> Hi Paul,
> 
> On 15.04.2011 [13:29:16 -0700], Paul E. McKenney wrote:
> > Hello!
> > 
> > The following patch fixes a UP build problem for kexec() on powerpc.
> > When the crash_kexec_wait_realmode() function was added, it was
> > placed in only two of the three required locations.
> 
> I believe the fix has already been posted as
> 
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html

So it has!  Thank you for the pointer.

							Thanx, Paul
diff mbox

Patch

diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
index 3d3d416..6f964ef 100644
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -251,6 +251,10 @@  static void crash_kexec_prepare_cpus(int cpu)
 #endif
 }
 
+static void crash_kexec_wait_realmode(int cpu)
+{
+}
+
 void crash_kexec_secondary(struct pt_regs *regs)
 {
 	cpus_in_sr = CPU_MASK_NONE;