[U-Boot,v2,3/7] serial: serial_msm: initialize uart only before relocation

Message ID 20180516091342.7509-3-ramon.fried@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot,v2,1/7] db820c: set clk node to be probed before relocation
Related show

Commit Message

Ramon Fried May 16, 2018, 9:13 a.m.
The uart is already initialized prior to relocation,
reinitialization after relocation is unnecessary.

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---
v2: removed extra parenthesis

 drivers/serial/serial_msm.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Glass May 16, 2018, 8:57 p.m. | #1
On 16 May 2018 at 03:13, Ramon Fried <ramon.fried@gmail.com> wrote:
> The uart is already initialized prior to relocation,
> reinitialization after relocation is unnecessary.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> ---
> v2: removed extra parenthesis
>
>  drivers/serial/serial_msm.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini May 28, 2018, 7:12 p.m. | #2
On Wed, May 16, 2018 at 12:13:38PM +0300, Ramon Fried wrote:

> The uart is already initialized prior to relocation,
> reinitialization after relocation is unnecessary.
> 
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c
index 8b585deeeb..a4279accb4 100644
--- a/drivers/serial/serial_msm.c
+++ b/drivers/serial/serial_msm.c
@@ -184,6 +184,10 @@  static int msm_serial_probe(struct udevice *dev)
 	int ret;
 	struct msm_serial_data *priv = dev_get_priv(dev);
 
+	/* No need to reinitialize the UART after relocation */
+	if (gd->flags & GD_FLG_RELOC)
+		return 0;
+
 	ret = msm_uart_clk_init(dev);
 	if (ret)
 		return ret;