diff mbox series

[2/3] OpenBMC: use 0x3a as OEM command for partial add esel

Message ID 20180515225041.1148-3-stewart@linux.ibm.com
State Accepted
Headers show
Series IPMI and BMC fixups | expand

Commit Message

Stewart Smith May 15, 2018, 10:50 p.m. UTC
It turns out this is the IBM way to do this and we (OPAL) were just
never really told about the change.

So, with the best public docs that are available being Hostboot
source, let's make the change!

See https://github.com/open-power/hostboot/blob/8e05a4399b/src/include/usr/ipmi/ipmiif.H#L115

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 platforms/astbmc/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith May 16, 2018, 10:47 p.m. UTC | #1
Stewart Smith <stewart@linux.ibm.com> writes:
> It turns out this is the IBM way to do this and we (OPAL) were just
> never really told about the change.
>
> So, with the best public docs that are available being Hostboot
> source, let's make the change!
>
> See https://github.com/open-power/hostboot/blob/8e05a4399b/src/include/usr/ipmi/ipmiif.H#L115
>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  platforms/astbmc/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged to master as of 66c499f969f4e9931738959fad9df96dabfc63b5 and into
6.0.1 due to the awesome nature of "urgh, really, we missed this for
this long and nobody noticed? Oh dear."

I'll take 1/3 and 3/3 in the series in master and not the 6.0.x unless
someone yells loud enough.
diff mbox series

Patch

diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
index d1ee0e888f64..470ab5de9ad1 100644
--- a/platforms/astbmc/common.c
+++ b/platforms/astbmc/common.c
@@ -429,5 +429,5 @@  const struct bmc_platform astbmc_ami = {
 
 const struct bmc_platform astbmc_openbmc = {
 	.name = "OpenBMC",
-	.ipmi_oem_partial_add_esel   = IPMI_CODE(0x32, 0xf0),
+	.ipmi_oem_partial_add_esel   = IPMI_CODE(0x3a, 0xf0),
 };