[1/3] AMI BMC: use 0x3a as OEM command

Message ID 20180515225041.1148-2-stewart@linux.ibm.com
State Accepted
Headers show
Series
  • IPMI and BMC fixups
Related show

Commit Message

Stewart Smith May 15, 2018, 10:50 p.m.
The 0x3a OEM command is for IBM commands, while 0x32 was for AMI ones.
Sometime in the P8 timeframe, AMI BMCs were changed to listen for our
commands on either 0x32 or 0x3a. Since 0x3a is the direction forward,
we'll use that, as P9 machines with AMI BMCs probably also want these
to work, and let's not bet that 0x32 will continue to be okay.

Suggested-by: Joseph Reynolds <jrey@us.ibm.com>
Suggested-by: Maury Zipse <zipse@us.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 platforms/astbmc/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith May 25, 2018, 12:23 a.m. | #1
Stewart Smith <stewart@linux.ibm.com> writes:
> The 0x3a OEM command is for IBM commands, while 0x32 was for AMI ones.
> Sometime in the P8 timeframe, AMI BMCs were changed to listen for our
> commands on either 0x32 or 0x3a. Since 0x3a is the direction forward,
> we'll use that, as P9 machines with AMI BMCs probably also want these
> to work, and let's not bet that 0x32 will continue to be okay.
>
> Suggested-by: Joseph Reynolds <jrey@us.ibm.com>
> Suggested-by: Maury Zipse <zipse@us.ibm.com>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  platforms/astbmc/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged to master as of e9227752364564581d591d0ecb5b56e7e9bc4244

Patch

diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
index 8b24abe5c31f..d1ee0e888f64 100644
--- a/platforms/astbmc/common.c
+++ b/platforms/astbmc/common.c
@@ -423,7 +423,7 @@  void astbmc_early_init(void)
 
 const struct bmc_platform astbmc_ami = {
 	.name = "AMI",
-	.ipmi_oem_partial_add_esel   = IPMI_CODE(0x32, 0xf0),
+	.ipmi_oem_partial_add_esel   = IPMI_CODE(0x3a, 0xf0),
 	.ipmi_oem_pnor_access_status = IPMI_CODE(0x3a, 0x07),
 };