[v2] x86-64: remove duplicate line on PREFETCH_ONE_SET macro

Message ID 20180515193238.14428-1-leonardo.sandoval.gonzalez@linux.intel.com
State New
Headers show
Series
  • [v2] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
Related show

Commit Message

Leonardo Sandoval May 15, 2018, 7:32 p.m.
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

Tested on 64-bit AVX machine

       * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
       (PREFETCH_ONE_SET): Remove duplicate line
---
 sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 1 -
 1 file changed, 1 deletion(-)

Comments

H.J. Lu May 15, 2018, 8:06 p.m. | #1
On Tue, May 15, 2018 at 12:32 PM,
<leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Tested on 64-bit AVX machine
>
>        * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
>        (PREFETCH_ONE_SET): Remove duplicate line
> ---
>  sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> index cbd0d077cf6..1404131bb71 100644
> --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> @@ -90,7 +90,6 @@
>  #  define PREFETCH_ONE_SET(dir, base, offset) \
>         PREFETCH ((offset)base); \
>         PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
> -       PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
>         PREFETCH ((offset + dir * PREFETCH_SIZE * 2)base); \
>         PREFETCH ((offset + dir * PREFETCH_SIZE * 3)base)
>  # else
> --
> 2.17.0
>

LGTM.

Thanks.

Patch

diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
index cbd0d077cf6..1404131bb71 100644
--- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
+++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
@@ -90,7 +90,6 @@ 
 #  define PREFETCH_ONE_SET(dir, base, offset) \
 	PREFETCH ((offset)base); \
 	PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
-	PREFETCH ((offset + dir * PREFETCH_SIZE)base); \
 	PREFETCH ((offset + dir * PREFETCH_SIZE * 2)base); \
 	PREFETCH ((offset + dir * PREFETCH_SIZE * 3)base)
 # else