| Message ID | 1526395734-333-11-git-send-email-alex.kiernan@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Joe Hershberger |
| Headers | show |
| Series | Add fastboot UDP support | expand |
On 15 May 2018 at 08:48, Alex Kiernan <alex.kiernan@gmail.com> wrote: > > Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code > we only have one definition. > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > --- > > Changes in v4: > - leave strcmp_l1() in USB fastboot as we don't need it in UDP path > > Changes in v3: > - new > > Changes in v2: None > > drivers/usb/gadget/f_fastboot.c | 2 -- > include/fastboot.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan <alex.kiernan@gmail.com> wrote: > Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code > we only have one definition. > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 697eee5..25784a1 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -27,8 +27,6 @@ #include <fb_nand.h> #endif -#define FASTBOOT_VERSION "0.4" - #define FASTBOOT_INTERFACE_CLASS 0xff #define FASTBOOT_INTERFACE_SUB_CLASS 0x42 #define FASTBOOT_INTERFACE_PROTOCOL 0x03 diff --git a/include/fastboot.h b/include/fastboot.h index f2ef51c..593e6a7 100644 --- a/include/fastboot.h +++ b/include/fastboot.h @@ -12,6 +12,8 @@ #ifndef _FASTBOOT_H_ #define _FASTBOOT_H_ +#define FASTBOOT_VERSION "0.4" + /* The 64 defined bytes plus \0 */ #define FASTBOOT_RESPONSE_LEN (64 + 1)
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> --- Changes in v4: - leave strcmp_l1() in USB fastboot as we don't need it in UDP path Changes in v3: - new Changes in v2: None drivers/usb/gadget/f_fastboot.c | 2 -- include/fastboot.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)