Patchwork [1/2] ARM: mxs: add GPMI support for imx23/imx28

login
register
mail settings
Submitter Huang Shijie
Date April 15, 2011, 8:01 a.m.
Message ID <1302854508-13652-1-git-send-email-b32955@freescale.com>
Download mbox | patch
Permalink /patch/91328/
State New
Headers show

Comments

Huang Shijie - April 15, 2011, 8:01 a.m.
add gpmi support for imx23 and imx28.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 arch/arm/mach-mxs/Kconfig                 |    2 +
 arch/arm/mach-mxs/include/mach/gpmi-nfc.h |   68 +++++++++++++++++++++++++++++
 2 files changed, 70 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mxs/include/mach/gpmi-nfc.h
Uwe Kleine-König - April 15, 2011, 8:06 a.m.
On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> +#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
Is it sensible to keep these when they are only used in a single .c
file?
Huang Shijie - April 15, 2011, 8:13 a.m.
> On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
>> +#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
> Is it sensible to keep these when they are only used in a single .c
> file?
>
I also use these in gpmi driver for distinguish platform id.
Do i have to remove these lines , and use the hardcode?
Uwe Kleine-König - April 15, 2011, 8:42 a.m.
On Fri, Apr 15, 2011 at 04:13:43PM +0800, Huang Shijie wrote:
> >On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> >>+#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
> >Is it sensible to keep these when they are only used in a single .c
> >file?
> >
> I also use these in gpmi driver for distinguish platform id.
> Do i have to remove these lines , and use the hardcode?
Ah, I missed the usage in the header. *shrug*, I don't care much, but
I'd use hardcoding.

BTW, as the driver name is gpmi-nfc this should be used for the various
names introduced in this patch set. (i.e. mx28_add_gpmi_nfc,
MXS_HAS_PLATFORM_GPMI_NFC etc.)

Best regards
Uwe
Huang Shijie - April 15, 2011, 8:50 a.m.
hi,
> On Fri, Apr 15, 2011 at 04:13:43PM +0800, Huang Shijie wrote:
>>> On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
>>>> +#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
>>>> +#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
>>>> +#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
>>>> +#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
>>> Is it sensible to keep these when they are only used in a single .c
>>> file?
>>>
>> I also use these in gpmi driver for distinguish platform id.
>> Do i have to remove these lines , and use the hardcode?
> Ah, I missed the usage in the header. *shrug*, I don't care much, but
> I'd use hardcoding.
>
ok. I will change it in the next version.

> BTW, as the driver name is gpmi-nfc this should be used for the various
> names introduced in this patch set. (i.e. mx28_add_gpmi_nfc,
> MXS_HAS_PLATFORM_GPMI_NFC etc.)
thanks.

Best Regards
Huang Shijie
> Best regards
> Uwe
>

Patch

diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
index 4f6f174..e034666 100644
--- a/arch/arm/mach-mxs/Kconfig
+++ b/arch/arm/mach-mxs/Kconfig
@@ -22,6 +22,7 @@  config MACH_MX23EVK
 	select SOC_IMX23
 	select MXS_HAVE_AMBA_DUART
 	select MXS_HAVE_PLATFORM_AUART
+	select MXS_HAVE_PLATFORM_GPMI
 	select MXS_HAVE_PLATFORM_MXSFB
 	default y
 	help
@@ -35,6 +36,7 @@  config MACH_MX28EVK
 	select MXS_HAVE_PLATFORM_AUART
 	select MXS_HAVE_PLATFORM_FEC
 	select MXS_HAVE_PLATFORM_FLEXCAN
+	select MXS_HAVE_PLATFORM_GPMI
 	select MXS_HAVE_PLATFORM_MXSFB
 	select MXS_OCOTP
 	default y
diff --git a/arch/arm/mach-mxs/include/mach/gpmi-nfc.h b/arch/arm/mach-mxs/include/mach/gpmi-nfc.h
new file mode 100644
index 0000000..32c8ad9
--- /dev/null
+++ b/arch/arm/mach-mxs/include/mach/gpmi-nfc.h
@@ -0,0 +1,68 @@ 
+/*
+ * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#ifndef __INCLUDE_GPMI_DEVICE_H
+#define __INCLUDE_GPMI_DEVICE_H
+
+#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
+#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
+#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
+#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
+
+/* The size of the resource is fixed. */
+#define RES_SIZE	6
+
+/* Resource names for the GPMI NFC driver. */
+#define GPMI_NFC_GPMI_REGS_ADDR_RES_NAME  "GPMI NFC GPMI Registers"
+#define GPMI_NFC_GPMI_INTERRUPT_RES_NAME  "GPMI NFC GPMI Interrupt"
+#define GPMI_NFC_BCH_REGS_ADDR_RES_NAME   "GPMI NFC BCH Registers"
+#define GPMI_NFC_BCH_INTERRUPT_RES_NAME   "GPMI NFC BCH Interrupt"
+#define GPMI_NFC_DMA_CHANNELS_RES_NAME    "GPMI NFC DMA Channels"
+#define GPMI_NFC_DMA_INTERRUPT_RES_NAME   "GPMI NFC DMA Interrupt"
+
+/**
+ * struct gpmi_nfc_platform_data - GPMI NFC driver platform data.
+ *
+ * This structure communicates platform-specific information to the GPMI NFC
+ * driver that can't be expressed as resources.
+ *
+ * @min_prop_delay_in_ns:    Minimum propagation delay of GPMI signals to and
+ *                           from the NAND Flash device, in nanoseconds.
+ * @max_prop_delay_in_ns:    Maximum propagation delay of GPMI signals to and
+ *                           from the NAND Flash device, in nanoseconds.
+ * @max_chip_count:          The maximum number of chips for which the driver
+ *                           should configure the hardware. This value most
+ *                           likely reflects the number of pins that are
+ *                           connected to a NAND Flash device. If this is
+ *                           greater than the SoC hardware can support, the
+ *                           driver will print a message and fail to initialize.
+ * @partitions:              An optional pointer to an array of partition
+ *                           descriptions.
+ * @partition_count:         The number of elements in the partitions array.
+ */
+struct gpmi_nfc_platform_data {
+	/* NAND Flash information. */
+	unsigned int          min_prop_delay_in_ns;
+	unsigned int          max_prop_delay_in_ns;
+	unsigned int          max_chip_count;
+
+	/* soc */
+	struct mtd_partition  *partitions;
+	unsigned              partition_count;
+};
+#endif