diff mbox series

[U-Boot,3/3] doc: qemu-arm: Drop highmem=off references

Message ID 20180514154752.31081-3-tuomas.tynkkynen@iki.fi
State Accepted
Commit 9792be7d933ed58ab7ff46a21b37f312a4c04682
Delegated to: Tom Rini
Headers show
Series [U-Boot,1/3] PCI: dm: Ignore 64-bit memory regions if CONFIG_SYS_PCI_64BIT not set | expand

Commit Message

Tuomas Tynkkynen May 14, 2018, 3:47 p.m. UTC
Now that U-Boot works fine with highmem enabled, there is no need to
tell users to disable highmem.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
---
 doc/README.qemu-arm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Simon Glass May 14, 2018, 7:51 p.m. UTC | #1
On 14 May 2018 at 09:47, Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> wrote:
> Now that U-Boot works fine with highmem enabled, there is no need to
> tell users to disable highmem.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  doc/README.qemu-arm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini May 28, 2018, 7:12 p.m. UTC | #2
On Mon, May 14, 2018 at 06:47:52PM +0300, Tuomas Tynkkynen wrote:

> Now that U-Boot works fine with highmem enabled, there is no need to
> tell users to disable highmem.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
Jonathan Gray Sept. 4, 2018, 6:22 a.m. UTC | #3
On Mon, May 14, 2018 at 06:47:52PM +0300, Tuomas Tynkkynen wrote:
> Now that U-Boot works fine with highmem enabled, there is no need to
> tell users to disable highmem.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  doc/README.qemu-arm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/doc/README.qemu-arm b/doc/README.qemu-arm
> index 6f6f07d8bb..260165638a 100644
> --- a/doc/README.qemu-arm
> +++ b/doc/README.qemu-arm
> @@ -39,13 +39,12 @@ Running U-Boot
>  The minimal QEMU command line to get U-Boot up and running is:
>
>  - For ARM:
> -    qemu-system-arm -machine virt,highmem=off -bios u-boot.bin
> +    qemu-system-arm -machine virt -bios u-boot.bin
>
>  - For AArch64:
> -    qemu-system-aarch64 -machine virt,highmem=off -cpu cortex-a57 -bios u-boot.bin
> +    qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin
>
> -The 'highmem=off' parameter to the 'virt' machine is required for PCI to work
> -in U-Boot. Also, for some odd reason qemu-system-aarch64 needs to be explicitly
> +Note that for some odd reason qemu-system-aarch64 needs to be explicitly
>  told to use a 64-bit CPU or it will boot in 32-bit mode.
>
>  Additional peripherals that have been tested to work in both U-Boot and Linux

Something has changed as qemu 3.0 requires highmem=off again.
qemu 2.12.0 works without highmem=off.

$ qemu-system-aarch64 --version
QEMU emulator version 3.0.0
Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers
$ qemu-system-aarch64 -M virt -cpu cortex-a57 -bios u-boot.bin -serial stdio

U-Boot 2018.09-rc3 (Sep 04 2018 - 13:03:12 +1000)

DRAM:  128 MiB
In:    pl011@9000000
Out:   pl011@9000000
Err:   pl011@9000000
Net:   No ethernet found.
"Synchronous Abort" handler, esr 0x96000005
elr: 00000000000258e0 lr : 000000000002589c (reloc)
elr: 0000000047f978e0 lr : 0000000047f9789c
x0 : 000000401000000e x1 : 0000000000000000
x2 : 000000401000000e x3 : 0000000046e608c8
x4 : 0000004010000000 x5 : 0000000000000000
x6 : 0000000047f9889c x7 : 0000000000000002
x8 : 0000000000000003 x9 : 0000000000000004
x10: 0000000046e60de8 x11: 000000000000152c
x12: 0000000046e6089c x13: 0000000000001200
x14: 0000000046e6092c x15: 0000000046e60de8
x16: 0000000000000000 x17: 0000000000000000
x18: 0000000046f61de8 x19: 0000000046e60940
x20: 0000000000000000 x21: 0000000047fcc0a8
x22: 0000000046f62450 x23: 0000000047fcc680
x24: 000000000000ff00 x25: 0000000000000000
x26: 0000000047fcc000 x27: 0000000000000000
x28: 0000000000000000 x29: 0000000046e608a0

Resetting CPU ...

resetting ...

$ qemu-system-aarch64 -M virt,highmem=off -cpu cortex-a57 -bios u-boot.bin -serial stdio

U-Boot 2018.09-rc3 (Sep 04 2018 - 13:03:12 +1000)

DRAM:  128 MiB
In:    pl011@9000000
Out:   pl011@9000000
Err:   pl011@9000000
Net:   No ethernet found.
Hit any key to stop autoboot:  0 
scanning bus for devices...

Device 0: unknown device
=>
diff mbox series

Patch

diff --git a/doc/README.qemu-arm b/doc/README.qemu-arm
index 6f6f07d8bb..260165638a 100644
--- a/doc/README.qemu-arm
+++ b/doc/README.qemu-arm
@@ -39,13 +39,12 @@  Running U-Boot
 The minimal QEMU command line to get U-Boot up and running is:
 
 - For ARM:
-    qemu-system-arm -machine virt,highmem=off -bios u-boot.bin
+    qemu-system-arm -machine virt -bios u-boot.bin
 
 - For AArch64:
-    qemu-system-aarch64 -machine virt,highmem=off -cpu cortex-a57 -bios u-boot.bin
+    qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin
 
-The 'highmem=off' parameter to the 'virt' machine is required for PCI to work
-in U-Boot. Also, for some odd reason qemu-system-aarch64 needs to be explicitly
+Note that for some odd reason qemu-system-aarch64 needs to be explicitly
 told to use a 64-bit CPU or it will boot in 32-bit mode.
 
 Additional peripherals that have been tested to work in both U-Boot and Linux