| Message ID | 1526308035-12484-4-git-send-email-vladbu@mellanox.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | Modify action API for implementing lockless actions | expand |
Mon, May 14, 2018 at 04:27:04PM CEST, vladbu@mellanox.com wrote: >Extend action ops with 'delete' function. Each action type to implement its >own delete function that doesn't depend on rtnl lock. > >Signed-off-by: Vlad Buslov <vladbu@mellanox.com> >--- > include/net/act_api.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/include/net/act_api.h b/include/net/act_api.h >index e634014..73175a3 100644 >--- a/include/net/act_api.h >+++ b/include/net/act_api.h >@@ -100,6 +100,7 @@ struct tc_action_ops { > void (*stats_update)(struct tc_action *, u64, u32, u64); > size_t (*get_fill_size)(const struct tc_action *act); > struct net_device *(*get_dev)(const struct tc_action *a); >+ int (*delete)(struct net *net, u32 index); Probably better to squash this to patch 14. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Mon, May 14, 2018 at 05:12:22PM CEST, jiri@resnulli.us wrote: >Mon, May 14, 2018 at 04:27:04PM CEST, vladbu@mellanox.com wrote: >>Extend action ops with 'delete' function. Each action type to implement its >>own delete function that doesn't depend on rtnl lock. >> >>Signed-off-by: Vlad Buslov <vladbu@mellanox.com> >>--- >> include/net/act_api.h | 1 + >> 1 file changed, 1 insertion(+) >> >>diff --git a/include/net/act_api.h b/include/net/act_api.h >>index e634014..73175a3 100644 >>--- a/include/net/act_api.h >>+++ b/include/net/act_api.h >>@@ -100,6 +100,7 @@ struct tc_action_ops { >> void (*stats_update)(struct tc_action *, u64, u32, u64); >> size_t (*get_fill_size)(const struct tc_action *act); >> struct net_device *(*get_dev)(const struct tc_action *a); >>+ int (*delete)(struct net *net, u32 index); > >Probably better to squash this to patch 14. Oh, I see you call it in patch 6. Fine. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/act_api.h b/include/net/act_api.h index e634014..73175a3 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h @@ -100,6 +100,7 @@ struct tc_action_ops { void (*stats_update)(struct tc_action *, u64, u32, u64); size_t (*get_fill_size)(const struct tc_action *act); struct net_device *(*get_dev)(const struct tc_action *a); + int (*delete)(struct net *net, u32 index); }; struct tc_action_net {
Extend action ops with 'delete' function. Each action type to implement its own delete function that doesn't depend on rtnl lock. Signed-off-by: Vlad Buslov <vladbu@mellanox.com> --- include/net/act_api.h | 1 + 1 file changed, 1 insertion(+)