diff mbox series

[v3] ipvlan: call netdevice notifier when master mac address changed

Message ID 20180514113809.10196-1-liuqifa@huawei.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [v3] ipvlan: call netdevice notifier when master mac address changed | expand

Commit Message

liuqifa May 14, 2018, 11:38 a.m. UTC 
From: Keefe Liu <liuqifa@huawei.com>

When master device's mac has been changed, the commit
32c10bbfe914 ("ipvlan: always use the current L2 addr of the
master") makes the IPVlan devices's mac changed also, but it
doesn't do related works such as flush the IPVlan devices's
arp table.

Signed-off-by: Keefe Liu <liuqifa@huawei.com>
---
 drivers/net/ipvlan/ipvlan_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

David Miller May 16, 2018, 4 p.m. UTC | #1 
From: <liuqifa@huawei.com>
Date: Mon, 14 May 2018 19:38:09 +0800

> From: Keefe Liu <liuqifa@huawei.com>
> 
> When master device's mac has been changed, the commit
> 32c10bbfe914 ("ipvlan: always use the current L2 addr of the
> master") makes the IPVlan devices's mac changed also, but it
> doesn't do related works such as flush the IPVlan devices's
> arp table.
> 
> Signed-off-by: Keefe Liu <liuqifa@huawei.com>

Applied and queued up for -stable, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 450eec2..4377c26 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -792,8 +792,10 @@  static int ipvlan_device_event(struct notifier_block *unused,
 		break;
 
 	case NETDEV_CHANGEADDR:
-		list_for_each_entry(ipvlan, &port->ipvlans, pnode)
+		list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
 			ether_addr_copy(ipvlan->dev->dev_addr, dev->dev_addr);
+			call_netdevice_notifiers(NETDEV_CHANGEADDR, ipvlan->dev);
+		}
 		break;
 
 	case NETDEV_PRE_TYPE_CHANGE: