diff mbox series

[U-Boot,v3,07/13] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

Message ID 1526288948-24977-8-git-send-email-alex.kiernan@gmail.com
State Superseded
Delegated to: Joe Hershberger
Headers show
Series Add fastboot UDP support | expand

Commit Message

Alex Kiernan May 14, 2018, 9:09 a.m. UTC
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined
by Kconfig if you're compiling this code, so remove these redundant
defaults.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---

Changes in v3:
- new

Changes in v2: None

 drivers/fastboot/fb_mmc.c | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Simon Glass May 14, 2018, 7:52 p.m. UTC | #1
On 14 May 2018 at 03:09, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined
> by Kconfig if you're compiling this code, so remove these redundant
> defaults.
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
>
> Changes in v3:
> - new
>
> Changes in v2: None
>
>  drivers/fastboot/fb_mmc.c | 13 -------------
>  1 file changed, 13 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index b1db296..038905f 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -15,19 +15,6 @@ 
 #include <linux/compat.h>
 #include <android_image.h>
 
-/*
- * FIXME: Ensure we always set these names via Kconfig once xxx_PARTITION is
- * migrated
- */
-#ifndef CONFIG_FASTBOOT_GPT_NAME
-#define CONFIG_FASTBOOT_GPT_NAME "gpt"
-#endif
-
-
-#ifndef CONFIG_FASTBOOT_MBR_NAME
-#define CONFIG_FASTBOOT_MBR_NAME "mbr"
-#endif
-
 #define BOOT_PARTITION_NAME "boot"
 
 struct fb_mmc_sparse {