From patchwork Mon May 14 05:49:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 912690 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UocGQbL/"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40kqWC1Lf5z9s19 for ; Mon, 14 May 2018 15:48:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbeENFsi (ORCPT ); Mon, 14 May 2018 01:48:38 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36080 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbeENFse (ORCPT ); Mon, 14 May 2018 01:48:34 -0400 Received: by mail-wm0-f65.google.com with SMTP id n10-v6so12639654wmc.1; Sun, 13 May 2018 22:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XsFO2VQUfH4nRgDiw6pQjFb0qTnfMTQTXVxlAJULJn8=; b=UocGQbL//2UqtK1vhBuR4ChnymRg95g3j5m2PHO/P7SNzOFaNVlzltcr2T6Uqm1Zyx t0258U5k2YWcB7rfUI6c5mJcRKd32n84dWAWxqJsA90/REDc7ptyFG/hTobbDX/Z4OK3 Yf3BfP6bDxULs2YYOXr9dI+97Yxikbllf2uWX4LsfwtEOqB02h32A2BIbDdU/EgC6KFg hK0ovd8CKrY76kcLu6WunvjoXZTotYmDaj3zmBcsRgL/SKrOstkqZLS7V2FyEnpSkkEO o7HRMbkPAKXWl1L7MbYG+mDCKcKt9rezdA1i0a9g4JGxbi9OpbY4pVwaV+Ube1PTL3ci +lJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XsFO2VQUfH4nRgDiw6pQjFb0qTnfMTQTXVxlAJULJn8=; b=aQU+RHpUAK39xDfuIOnDwDIK8BS+gnDnRGmJZwDbycfnmTa6Gj/ttJV6RioslG80CS GiGwxJg8f+/KWpQq6GlWBuFHlUkP0MIA943MZB4cHYpc0NdWoQJ42aRiEI5OOGmyeFHR oK/FM+zjKVLq+UhGcIEG2TLrbYQBP0I9uBFaRTYDOcPH6Vn93C8k+E0okLx0UExUAxKH BWU99aLZTT/K9p/0AZvmH5J5WY0efZ+KFmbJd3xyj4ddWAEUCHO7j/MNTSba1hfK0AuJ JBb3ZAP33HiZjICSbj1bKwP/LaS1q0Aq0W1xyl4bv+Wtnmm0+WpiVTD+lgHMcoOiK2Tj XLVQ== X-Gm-Message-State: ALKqPwdMEz/2NvOP3jBH525D10r4Jx1Z3qXLoHsvCFitF3zcICyp2LAJ TKVU9QXvwJ6ZNXkijrqLkLNy9g== X-Google-Smtp-Source: AB8JxZoYNSF+j5goNTGMzSK1JxqzLsOBL53ReteEPy7ZZaHeBFrJLEfanw59AvV09B71tHv7N+fbhQ== X-Received: by 2002:a1c:71dc:: with SMTP id d89-v6mr4034776wmi.26.1526276913372; Sun, 13 May 2018 22:48:33 -0700 (PDT) Received: from localhost.localdomain ([94.230.83.122]) by smtp.gmail.com with ESMTPSA id o12-v6sm12109404wrf.31.2018.05.13.22.48.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 13 May 2018 22:48:32 -0700 (PDT) From: Amir Goldstein To: Eryu Guan Cc: Theodore Ts'o , fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH 3/3] generic: test first read with freeze right after mount Date: Mon, 14 May 2018 08:49:51 +0300 Message-Id: <1526276991-23897-4-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526276991-23897-1-git-send-email-amir73il@gmail.com> References: <1526276991-23897-1-git-send-email-amir73il@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org With ext4, this leads to freeze proection bypass WARN_ON in ext4_journal_check_start. Signed-off-by: Amir Goldstein --- tests/generic/488 | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/488.out | 2 ++ tests/generic/group | 1 + 3 files changed, 78 insertions(+) create mode 100755 tests/generic/488 create mode 100644 tests/generic/488.out diff --git a/tests/generic/488 b/tests/generic/488 new file mode 100755 index 0000000..02cf489 --- /dev/null +++ b/tests/generic/488 @@ -0,0 +1,75 @@ +#! /bin/bash +# FS QA Test No. 488 +# +# Test first read with freeze right after mount. +# +# With ext4, this leads to freeze proection bypass WARN_ON in +# ext4_journal_check_start. +# +#----------------------------------------------------------------------- +# Copyright (C) 2018 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch +_require_freeze +_require_command "$TIMEOUT_PROG" "timeout" + +rm -f $seqres.full + +testfile=$SCRATCH_MNT/foo + +# Create a filesystem with a file +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount +echo "frozen" > $testfile + +# Mount filesystem "noatime" and freeze right after mount - +# reads should not block +_scratch_cycle_mount "noatime" +xfs_freeze -f $SCRATCH_MNT + +# Read file while filesystem is frozen should succeed +# without blocking +$TIMEOUT_PROG -s KILL 1s cat $testfile + +xfs_freeze -u $SCRATCH_MNT + +status=0 +exit diff --git a/tests/generic/488.out b/tests/generic/488.out new file mode 100644 index 0000000..0907d7c --- /dev/null +++ b/tests/generic/488.out @@ -0,0 +1,2 @@ +QA output created by 488 +frozen diff --git a/tests/generic/group b/tests/generic/group index dc637c9..ec993f7 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -490,3 +490,4 @@ 485 auto quick insert 486 auto quick attr 487 auto quick +488 auto quick freeze mount