Patchwork mtd: OOPS accessing flash operations over STM flash on PXA

login
register
mail settings
Submitter Denis V. Lunev
Date Nov. 17, 2008, 9:22 a.m.
Message ID <1226913735-9469-1-git-send-email-den@openvz.org>
Download mbox | patch
Permalink /patch/9124/
State New
Headers show

Comments

Denis V. Lunev - Nov. 17, 2008, 9:22 a.m.
STM 2Gb flash is a large-page NAND flash. Set operations accordingly.
This field is dereferrenced without a check in several places resulting
in OOPS (seen in reality).

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 drivers/mtd/nand/pxa3xx_nand.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index c0fa9c9..15f0a26 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -269,6 +269,7 @@  static struct pxa3xx_nand_timing stm2GbX16_timing = {
 
 static struct pxa3xx_nand_flash stm2GbX16 = {
 	.timing = &stm2GbX16_timing,
+	.cmdset	= &largepage_cmdset,
 	.page_per_block = 64,
 	.page_size = 2048,
 	.flash_width = 16,