Message ID | 1526008947-26667-2-git-send-email-yoshihiro.shimoda.uh@renesas.com |
---|---|
State | New |
Headers | show |
Series | pinctrl: sh-pfc: Initial R8A77990 PFC support | expand |
Hi Shimoda-san, On Fri, May 11, 2018 at 5:22 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This follows the style of existion PORT_GP_X macros and > will be used by a follow-up patch for the r8a77990 SoC. Thanks for your patch! > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in sh-pfc-for-v4.18... > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -415,9 +415,13 @@ struct sh_pfc_soc_info { > PORT_GP_CFG_1(bank, 9, fn, sfx, cfg) > #define PORT_GP_10(bank, fn, sfx) PORT_GP_CFG_10(bank, fn, sfx, 0) > > -#define PORT_GP_CFG_12(bank, fn, sfx, cfg) \ > +#define PORT_GP_CFG_11(bank, fn, sfx, cfg) \ > PORT_GP_CFG_10(bank, fn, sfx, cfg), \ > - PORT_GP_CFG_1(bank, 10, fn, sfx, cfg), \ > + PORT_GP_CFG_1(bank, 10, fn, sfx, cfg) ... with one space in fron of "fn" removed. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index 7fad897..b1a9957 100644 --- a/drivers/pinctrl/sh-pfc/sh_pfc.h +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h @@ -415,9 +415,13 @@ struct sh_pfc_soc_info { PORT_GP_CFG_1(bank, 9, fn, sfx, cfg) #define PORT_GP_10(bank, fn, sfx) PORT_GP_CFG_10(bank, fn, sfx, 0) -#define PORT_GP_CFG_12(bank, fn, sfx, cfg) \ +#define PORT_GP_CFG_11(bank, fn, sfx, cfg) \ PORT_GP_CFG_10(bank, fn, sfx, cfg), \ - PORT_GP_CFG_1(bank, 10, fn, sfx, cfg), \ + PORT_GP_CFG_1(bank, 10, fn, sfx, cfg) +#define PORT_GP_11(bank, fn, sfx) PORT_GP_CFG_11(bank, fn, sfx, 0) + +#define PORT_GP_CFG_12(bank, fn, sfx, cfg) \ + PORT_GP_CFG_11(bank, fn, sfx, cfg), \ PORT_GP_CFG_1(bank, 11, fn, sfx, cfg) #define PORT_GP_12(bank, fn, sfx) PORT_GP_CFG_12(bank, fn, sfx, 0)