| Message ID | 1526001148-6569-1-git-send-email-brett.grandbois@opengear.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | configure: only test for msgfmt if NLS enabled | expand |
On Fri, 2018-05-11 at 11:12 +1000, Brett Grandbois wrote: > in environments where --disable-nls is specified msgfmt is unnecessary > and therefore may not be available > > Signed-off-by: Brett Grandbois <brett.grandbois@opengear.com> I assume this blew up somewhere; thanks for the fixup. Merged as 80c9b41. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 1fa0ea4..564cb5d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -39,7 +39,7 @@ AM_INIT_AUTOMAKE > AC_GNU_SOURCE > AM_GNU_GETTEXT([external]) > AM_GNU_GETTEXT_VERSION(0.18.1) > -if test -z "$($MSGFMT --version)"; then > +if test "$USE_NLS" = "yes" -a -z "$($MSGFMT --version)"; then > AC_MSG_ERROR([[Please install gettext]]) > fi > LT_INIT
On 14/05/18 15:46, Samuel Mendoza-Jonas wrote: > On Fri, 2018-05-11 at 11:12 +1000, Brett Grandbois wrote: >> in environments where --disable-nls is specified msgfmt is unnecessary >> and therefore may not be available >> >> Signed-off-by: Brett Grandbois <brett.grandbois@opengear.com> > I assume this blew up somewhere; thanks for the fixup. Merged as 80c9b41. Yep. We currently have NLS disabled and in Yocto-land if it detects that it doesn't populate gettext and friends in the system root. > >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index 1fa0ea4..564cb5d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -39,7 +39,7 @@ AM_INIT_AUTOMAKE >> AC_GNU_SOURCE >> AM_GNU_GETTEXT([external]) >> AM_GNU_GETTEXT_VERSION(0.18.1) >> -if test -z "$($MSGFMT --version)"; then >> +if test "$USE_NLS" = "yes" -a -z "$($MSGFMT --version)"; then >> AC_MSG_ERROR([[Please install gettext]]) >> fi >> LT_INIT
diff --git a/configure.ac b/configure.ac index 1fa0ea4..564cb5d 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ AM_INIT_AUTOMAKE AC_GNU_SOURCE AM_GNU_GETTEXT([external]) AM_GNU_GETTEXT_VERSION(0.18.1) -if test -z "$($MSGFMT --version)"; then +if test "$USE_NLS" = "yes" -a -z "$($MSGFMT --version)"; then AC_MSG_ERROR([[Please install gettext]]) fi LT_INIT
in environments where --disable-nls is specified msgfmt is unnecessary and therefore may not be available Signed-off-by: Brett Grandbois <brett.grandbois@opengear.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)