[v2,9/9] PCI: spear13xx: Drop unnecessary root_bus_nr setting

Message ID 1525998019-28634-10-git-send-email-shawn.guo@linaro.org
State Needs Review / ACK
Delegated to: Lorenzo Pieralisi
Headers show
Series
  • PCI: dwc: Drop unnecessary root_bus_nr setting
Related show

Commit Message

Shawn Guo May 11, 2018, 12:20 a.m.
Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Pratyush Anand <pratyush.anand@gmail.com>
---
 drivers/pci/dwc/pcie-spear13xx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Pratyush Anand May 11, 2018, 6:17 a.m. | #1
On Fri, May 11, 2018 at 5:50 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>

Acked-by: Pratyush Anand <pratyush.anand@gmail.com>

> ---
>  drivers/pci/dwc/pcie-spear13xx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c
> index ecb58f7b7566..7d0cdfd8138b 100644
> --- a/drivers/pci/dwc/pcie-spear13xx.c
> +++ b/drivers/pci/dwc/pcie-spear13xx.c
> @@ -210,7 +210,6 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
>                 return ret;
>         }
>
> -       pp->root_bus_nr = -1;
>         pp->ops = &spear13xx_pcie_host_ops;
>
>         ret = dw_pcie_host_init(pp);
> --
> 1.9.1
>

Patch

diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c
index ecb58f7b7566..7d0cdfd8138b 100644
--- a/drivers/pci/dwc/pcie-spear13xx.c
+++ b/drivers/pci/dwc/pcie-spear13xx.c
@@ -210,7 +210,6 @@  static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
 		return ret;
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &spear13xx_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);