[v6,05/12] PCI: hotplug: Convert SHPC to be builtin only

Message ID 20180510182844.77349-6-mika.westerberg@linux.intel.com
State Superseded
Delegated to: Bjorn Helgaas
Headers show
Series
  • PCI: Fixes and cleanups for native PCIe, SHPC and ACPI hotplug
Related show

Commit Message

Mika Westerberg May 10, 2018, 6:28 p.m.
We need to be able coordinate between SHPC and acpiphp in order to
determine which driver handles hotplug of a given bridge. Because
acpiphp is already bool convert SHPC to be bool as well.

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/pci/hotplug/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Rafael J. Wysocki May 15, 2018, 9:18 a.m. | #1
On Thursday, May 10, 2018 8:28:37 PM CEST Mika Westerberg wrote:
> We need to be able coordinate between SHPC and acpiphp in order to
> determine which driver handles hotplug of a given bridge. Because
> acpiphp is already bool convert SHPC to be bool as well.
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  drivers/pci/hotplug/Kconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index a8f21d051e0c..e9f78eb390d2 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -104,14 +104,11 @@ config HOTPLUG_PCI_CPCI_GENERIC
>  	  When in doubt, say N.
>  
>  config HOTPLUG_PCI_SHPC
> -	tristate "SHPC PCI Hotplug driver"
> +	bool "SHPC PCI Hotplug driver"
>  	help
>  	  Say Y here if you have a motherboard with a SHPC PCI Hotplug
>  	  controller.
>  
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called shpchp.
> -
>  	  When in doubt, say N.
>  
>  config HOTPLUG_PCI_POWERNV
> 

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Patch

diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
index a8f21d051e0c..e9f78eb390d2 100644
--- a/drivers/pci/hotplug/Kconfig
+++ b/drivers/pci/hotplug/Kconfig
@@ -104,14 +104,11 @@  config HOTPLUG_PCI_CPCI_GENERIC
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_SHPC
-	tristate "SHPC PCI Hotplug driver"
+	bool "SHPC PCI Hotplug driver"
 	help
 	  Say Y here if you have a motherboard with a SHPC PCI Hotplug
 	  controller.
 
-	  To compile this driver as a module, choose M here: the
-	  module will be called shpchp.
-
 	  When in doubt, say N.
 
 config HOTPLUG_PCI_POWERNV