Message ID | 20180510174519.11264-1-peter.maydell@linaro.org |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180510174519.11264-1-peter.maydell@linaro.org Subject: [Qemu-devel] [PULL 00/21] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180502221552.3873-1-richard.henderson@linaro.org -> patchew/20180502221552.3873-1-richard.henderson@linaro.org t [tag update] patchew/20180503115620.10596-1-edgar.iglesias@gmail.com -> patchew/20180503115620.10596-1-edgar.iglesias@gmail.com t [tag update] patchew/20180509165530.29561-1-mreitz@redhat.com -> patchew/20180509165530.29561-1-mreitz@redhat.com t [tag update] patchew/20180510094206.15354-1-alex.bennee@linaro.org -> patchew/20180510094206.15354-1-alex.bennee@linaro.org t [tag update] patchew/20180510140141.12120-1-peter.maydell@linaro.org -> patchew/20180510140141.12120-1-peter.maydell@linaro.org t [tag update] patchew/20180510140934.22855-1-peter.maydell@linaro.org -> patchew/20180510140934.22855-1-peter.maydell@linaro.org t [tag update] patchew/20180510143618.23673-1-peter.maydell@linaro.org -> patchew/20180510143618.23673-1-peter.maydell@linaro.org * [new tag] patchew/20180510174519.11264-1-peter.maydell@linaro.org -> patchew/20180510174519.11264-1-peter.maydell@linaro.org Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Switched to a new branch 'test' ccdba81c4b target/arm: Clear SVE high bits for FMOV 64003f64f0 target/arm: Fix float16 to/from int16 600be1201a target/arm: Implement vector shifted FCVT for fp16 0f941356c9 target/arm: Implement vector shifted SCVF/UCVF for fp16 3ded533d22 target/arm: Enable ARM_FEATURE_V8_ATOMICS for user-only 9d58b9b45c target/arm: Implement CAS and CASP 51a26a9014 target/arm: Fill in disas_ldst_atomic de4ccb142c target/arm: Introduce ARM_FEATURE_V8_ATOMICS and initial decode 3b7e02239c target/riscv: Use new atomic min/max expanders d8820204cf tcg: Use GEN_ATOMIC_HELPER_FN for opposite endian atomic add 587522510f tcg: Introduce atomic helpers for integer min/max adbe86c2cb target/xtensa: Use new min/max expanders 9f9ed0f8b4 target/arm: Use new min/max expanders 0386c2a4f5 tcg: Introduce helpers for integer min/max 7a13cbc1df atomic.h: Work around gcc spurious "unused value" warning 704fd2643a make sure that we aren't overwriting mc->get_hotplug_handler by accident e35977cfc3 arm/boot: split load_dtb() from arm_load_kernel() b46a5f4740 platform-bus-device: use device plug callback instead of machine_done notifier 318eae8151 pc: simplify MachineClass::get_hotplug_handler handling d99828cef6 softfloat: Handle default NaN mode after pickNaNMulAdd, not before 058260b178 hw/arm/iotkit.c: fix minor memory leak === OUTPUT BEGIN === Checking PATCH 1/21: hw/arm/iotkit.c: fix minor memory leak... Checking PATCH 2/21: softfloat: Handle default NaN mode after pickNaNMulAdd, not before... Checking PATCH 3/21: pc: simplify MachineClass::get_hotplug_handler handling... Checking PATCH 4/21: platform-bus-device: use device plug callback instead of machine_done notifier... Checking PATCH 5/21: arm/boot: split load_dtb() from arm_load_kernel()... Checking PATCH 6/21: make sure that we aren't overwriting mc->get_hotplug_handler by accident... Checking PATCH 7/21: atomic.h: Work around gcc spurious "unused value" warning... Checking PATCH 8/21: tcg: Introduce helpers for integer min/max... Checking PATCH 9/21: target/arm: Use new min/max expanders... Checking PATCH 10/21: target/xtensa: Use new min/max expanders... Checking PATCH 11/21: tcg: Introduce atomic helpers for integer min/max... ERROR: memory barrier without comment #58: FILE: accel/tcg/atomic_template.h:137: + smp_mb(); \ ERROR: memory barrier without comment #98: FILE: accel/tcg/atomic_template.h:285: + smp_mb(); \ total: 2 errors, 0 warnings, 236 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/21: tcg: Use GEN_ATOMIC_HELPER_FN for opposite endian atomic add... Checking PATCH 13/21: target/riscv: Use new atomic min/max expanders... Checking PATCH 14/21: target/arm: Introduce ARM_FEATURE_V8_ATOMICS and initial decode... Checking PATCH 15/21: target/arm: Fill in disas_ldst_atomic... Checking PATCH 16/21: target/arm: Implement CAS and CASP... Checking PATCH 17/21: target/arm: Enable ARM_FEATURE_V8_ATOMICS for user-only... Checking PATCH 18/21: target/arm: Implement vector shifted SCVF/UCVF for fp16... Checking PATCH 19/21: target/arm: Implement vector shifted FCVT for fp16... Checking PATCH 20/21: target/arm: Fix float16 to/from int16... ERROR: spaces required around that '*' (ctx:WxV) #47: FILE: target/arm/helper.c:11434: +static float16 do_postscale_fp16(float64 f, int shift, float_status *fpst) ^ total: 1 errors, 0 warnings, 83 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 21/21: target/arm: Clear SVE high bits for FMOV... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 10 May 2018 at 18:44, Peter Maydell <peter.maydell@linaro.org> wrote: > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-05-08 17:05:58 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180510 > > for you to fetch changes up to 9a9f1f59521f46e8ff4527d9a2b52f83577e2aa3: > > target/arm: Clear SVE high bits for FMOV (2018-05-10 18:10:58 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * hw/arm/iotkit.c: fix minor memory leak > * softfloat: fix wrong-exception-flags bug for multiply-add corner case > * arm: isolate and clean up DTB generation > * implement Arm v8.1-Atomics extension > * Fix some bugs and missing instructions in the v8.2-FP16 extension > Applied, thanks. -- PMM