[SRU,xenial/kvm] UBUNTU: Config: Enable CONFIG_AUDITSYSCALL

Message ID 20180509193322.2477-1-cascardo@canonical.com
State New
Headers show
Series
  • [SRU,xenial/kvm] UBUNTU: Config: Enable CONFIG_AUDITSYSCALL
Related show

Commit Message

Thadeu Lima de Souza Cascardo May 9, 2018, 7:33 p.m.
BugLink: https://bugs.launchpad.net/bugs/1770245

python os.getlogin() uses glibc getlogin(), which reads /proc/self/loginuid.

That file depends on CONFIG_AUDITSYSCALL. It has been there since early Linux
2.6. All our kernels should have it enabled.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 debian.kvm/config/config.common.ubuntu | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Po-Hsu Lin May 11, 2018, 3:18 a.m. | #1
Thanks for catching this.
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Kleber Souza May 14, 2018, 3:43 p.m. | #2
On 05/09/18 21:33, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1770245
> 
> python os.getlogin() uses glibc getlogin(), which reads /proc/self/loginuid.
> 
> That file depends on CONFIG_AUDITSYSCALL. It has been there since early Linux
> 2.6. All our kernels should have it enabled.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  debian.kvm/config/config.common.ubuntu | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index b1dca3c2a3e5..a76e17812c1e 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -129,9 +129,11 @@ CONFIG_ATA_VERBOSE_ERROR=y
>  # CONFIG_ATMEL_PIT is not set
>  # CONFIG_ATOMIC64_SELFTEST is not set
>  CONFIG_AUDIT=y
> -# CONFIG_AUDITSYSCALL is not set
> +CONFIG_AUDITSYSCALL=y
>  CONFIG_AUDIT_ARCH=y
>  # CONFIG_AUDIT_ARCH_COMPAT_GENERIC is not set
> +CONFIG_AUDIT_TREE=y
> +CONFIG_AUDIT_WATCH=y
>  CONFIG_AUFS_BDEV_LOOP=y
>  # CONFIG_AUFS_BRANCH_MAX_1023 is not set
>  CONFIG_AUFS_BRANCH_MAX_127=y
>
Kleber Souza May 15, 2018, 11:40 a.m. | #3
On 05/09/18 21:33, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1770245
> 
> python os.getlogin() uses glibc getlogin(), which reads /proc/self/loginuid.
> 
> That file depends on CONFIG_AUDITSYSCALL. It has been there since early Linux
> 2.6. All our kernels should have it enabled.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian.kvm/config/config.common.ubuntu | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index b1dca3c2a3e5..a76e17812c1e 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -129,9 +129,11 @@ CONFIG_ATA_VERBOSE_ERROR=y
>  # CONFIG_ATMEL_PIT is not set
>  # CONFIG_ATOMIC64_SELFTEST is not set
>  CONFIG_AUDIT=y
> -# CONFIG_AUDITSYSCALL is not set
> +CONFIG_AUDITSYSCALL=y
>  CONFIG_AUDIT_ARCH=y
>  # CONFIG_AUDIT_ARCH_COMPAT_GENERIC is not set
> +CONFIG_AUDIT_TREE=y
> +CONFIG_AUDIT_WATCH=y
>  CONFIG_AUFS_BDEV_LOOP=y
>  # CONFIG_AUFS_BRANCH_MAX_1023 is not set
>  CONFIG_AUFS_BRANCH_MAX_127=y
> 

Applied to xenial/linux-kvm/master-next branch.

Thanks,
Kleber

Patch

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index b1dca3c2a3e5..a76e17812c1e 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -129,9 +129,11 @@  CONFIG_ATA_VERBOSE_ERROR=y
 # CONFIG_ATMEL_PIT is not set
 # CONFIG_ATOMIC64_SELFTEST is not set
 CONFIG_AUDIT=y
-# CONFIG_AUDITSYSCALL is not set
+CONFIG_AUDITSYSCALL=y
 CONFIG_AUDIT_ARCH=y
 # CONFIG_AUDIT_ARCH_COMPAT_GENERIC is not set
+CONFIG_AUDIT_TREE=y
+CONFIG_AUDIT_WATCH=y
 CONFIG_AUFS_BDEV_LOOP=y
 # CONFIG_AUFS_BRANCH_MAX_1023 is not set
 CONFIG_AUFS_BRANCH_MAX_127=y