board: amarula: vyasa: Give raw space for falcon mode

Message ID 1525891389-6096-1-git-send-email-mayhs11saini@gmail.com
State Accepted
Commit 82d882eef0939ff98622dc8ec1ae724ae65befbc
Headers show
Series
  • board: amarula: vyasa: Give raw space for falcon mode
Related show

Commit Message

Shyam Saini May 9, 2018, 6:43 p.m.
From: Jagan Teki <jagan@amarulasolutions.com>

RK3288 Vyasa board support falcon mode in U-Boot and SD layout start from
16MB offset for args and 17MB for uImage. So give full u-boot partition
space as 30M so-that it can occupy bigger uImage file and doesn't overlap
rootfs partition.

Reported-by: Shyam Saini <shyam@amarulasolutions.com>
Tested-by: Shyam Saini <shyam@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: Shyam saini <shyam@amarulasolutions.com>
---
 board/amarula/vyasa/genimage.cfg | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard May 27, 2018, 8:03 p.m. | #1
>>>>> "shyam" == shyam saini <mayhs11saini@gmail.com> writes:

 > From: Jagan Teki <jagan@amarulasolutions.com>
 > RK3288 Vyasa board support falcon mode in U-Boot and SD layout start from
 > 16MB offset for args and 17MB for uImage. So give full u-boot partition
 > space as 30M so-that it can occupy bigger uImage file and doesn't overlap
 > rootfs partition.

 > Reported-by: Shyam Saini <shyam@amarulasolutions.com>
 > Tested-by: Shyam Saini <shyam@amarulasolutions.com>
 > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
 > Signed-off-by: Shyam saini <shyam@amarulasolutions.com>
 > ---
 >  board/amarula/vyasa/genimage.cfg | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/board/amarula/vyasa/genimage.cfg b/board/amarula/vyasa/genimage.cfg
 > index fa41de36720e..c8066ace9b68 100644
 > --- a/board/amarula/vyasa/genimage.cfg
 > +++ b/board/amarula/vyasa/genimage.cfg
 > @@ -12,6 +12,7 @@ image sdcard.img {
 >  		in-partition-table = "no"
 >  		image = "u-boot-dtb.img"
 >  		offset = 8M
 > +		size = 30M // falcon mode: 16M args, 17M uImage

We use # as comment character in all other genimage.cfg files, so I've
changed that. I also reworded to make it clear that these refers to
offsets and not sizes:

size = 30M # falcon mode: args @ 16M args, uImage @ 17M

Committed to next with that fixed, thanks.

Patch

diff --git a/board/amarula/vyasa/genimage.cfg b/board/amarula/vyasa/genimage.cfg
index fa41de36720e..c8066ace9b68 100644
--- a/board/amarula/vyasa/genimage.cfg
+++ b/board/amarula/vyasa/genimage.cfg
@@ -12,6 +12,7 @@  image sdcard.img {
 		in-partition-table = "no"
 		image = "u-boot-dtb.img"
 		offset = 8M
+		size = 30M // falcon mode: 16M args, 17M uImage
 	}
 
 	partition rootfs {