| Message ID | 20180509002812.13151-3-damien.lemoal@wdc.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | libata fixes and improvements | expand |
On 05/09/2018 02:28 AM, Damien Le Moal wrote: > Add proper error string output for ATA_ERR_NCQ and ATA_ERR_NODEV_HINT > instead of returning "unknown error". > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > drivers/ata/libata-eh.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > index d7b84bc64ae1..c6871c0749f7 100644 > --- a/drivers/ata/libata-eh.c > +++ b/drivers/ata/libata-eh.c > @@ -1483,6 +1483,10 @@ static const char *ata_err_string(unsigned int err_mask) > return "invalid argument"; > if (err_mask & AC_ERR_DEV) > return "device error"; > + if (err_mask & AC_ERR_NCQ) > + return "NCQ error"; > + if (err_mask & AC_ERR_NODEV_HINT) > + return "Polling detection error"; > return "unknown error"; > } > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index d7b84bc64ae1..c6871c0749f7 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -1483,6 +1483,10 @@ static const char *ata_err_string(unsigned int err_mask) return "invalid argument"; if (err_mask & AC_ERR_DEV) return "device error"; + if (err_mask & AC_ERR_NCQ) + return "NCQ error"; + if (err_mask & AC_ERR_NODEV_HINT) + return "Polling detection error"; return "unknown error"; }
Add proper error string output for ATA_ERR_NCQ and ATA_ERR_NODEV_HINT instead of returning "unknown error". Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/ata/libata-eh.c | 4 ++++ 1 file changed, 4 insertions(+)