[linux,dev-4.13] fsi: scom: Remove PIB reset during probe

Message ID 1525819412-21308-1-git-send-email-eajames@linux.vnet.ibm.com
State Accepted, archived
Headers show
Series
  • [linux,dev-4.13] fsi: scom: Remove PIB reset during probe
Related show

Commit Message

Eddie James May 8, 2018, 10:43 p.m.
The PIB reset causes problems for the running P9 chip. The reset
shouldn't be performed by this driver.

Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
---
 drivers/fsi/fsi-scom.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Christopher Bostic May 9, 2018, 1:59 p.m. | #1
Reviewed-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>


On 5/8/18 5:43 PM, Eddie James wrote:
> The PIB reset causes problems for the running P9 chip. The reset
> shouldn't be performed by this driver.
>
> Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
> ---
>   drivers/fsi/fsi-scom.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index e13353a..c8eb5e5 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -26,15 +26,11 @@
>
>   #define FSI_ENGID_SCOM		0x5
>
> -#define SCOM_FSI2PIB_DELAY	50
> -
>   /* SCOM engine register set */
>   #define SCOM_DATA0_REG		0x00
>   #define SCOM_DATA1_REG		0x04
>   #define SCOM_CMD_REG		0x08
> -#define SCOM_RESET_REG		0x1C
>
> -#define SCOM_RESET_CMD		0x80000000
>   #define SCOM_WRITE_CMD		0x80000000
>
>   struct scom_device {
> @@ -180,7 +176,6 @@ static loff_t scom_llseek(struct file *file, loff_t offset, int whence)
>
>   static int scom_probe(struct device *dev)
>   {
> -	uint32_t data;
>   	struct fsi_device *fsi_dev = to_fsi_dev(dev);
>   	struct scom_device *scom;
>
> @@ -197,9 +192,6 @@ static int scom_probe(struct device *dev)
>   	scom->mdev.parent = dev;
>   	list_add(&scom->link, &scom_devices);
>
> -	data = cpu_to_be32(SCOM_RESET_CMD);
> -	fsi_device_write(fsi_dev, SCOM_RESET_REG, &data, sizeof(uint32_t));
> -
>   	return misc_register(&scom->mdev);
>   }
>

Patch

diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index e13353a..c8eb5e5 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -26,15 +26,11 @@ 
 
 #define FSI_ENGID_SCOM		0x5
 
-#define SCOM_FSI2PIB_DELAY	50
-
 /* SCOM engine register set */
 #define SCOM_DATA0_REG		0x00
 #define SCOM_DATA1_REG		0x04
 #define SCOM_CMD_REG		0x08
-#define SCOM_RESET_REG		0x1C
 
-#define SCOM_RESET_CMD		0x80000000
 #define SCOM_WRITE_CMD		0x80000000
 
 struct scom_device {
@@ -180,7 +176,6 @@  static loff_t scom_llseek(struct file *file, loff_t offset, int whence)
 
 static int scom_probe(struct device *dev)
 {
-	uint32_t data;
 	struct fsi_device *fsi_dev = to_fsi_dev(dev);
 	struct scom_device *scom;
 
@@ -197,9 +192,6 @@  static int scom_probe(struct device *dev)
 	scom->mdev.parent = dev;
 	list_add(&scom->link, &scom_devices);
 
-	data = cpu_to_be32(SCOM_RESET_CMD);
-	fsi_device_write(fsi_dev, SCOM_RESET_REG, &data, sizeof(uint32_t));
-
 	return misc_register(&scom->mdev);
 }